Add ability to scroll village / storesContainer via keyboard #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove ^M from file because to heck with them.
|
This is a good start, opens the question on scrolling, when pushing down I expect the bar to go up. Does the current way feel natural to others? This doesn't solve the overflow on the starting page of A Dusty Path either. But like I said a great start! |
|
Wasn't seeing the overflow on Dusty path. I'm guessing it has to do with a full store and full perks? |
|
While you actually can see everything, I dont think I have all perks on this save and its clipped the bottom. By no means is it a deal breaker, Outside is much worse. |
|
Should be a relatively simple process, but it does cause me to rethink the placement of the movement functions. I feel they're better put now in Engine (referencing the inView and scrollByX functions) |
|
+1 |
Conflicts: script/outside.js script/path.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References Issue #115
When on Outside tab, if village / storesContainer expand beyond the viewport, this PR allows you to use your keyboard's up and down keys to scroll the sidebar.
Future enhancement could be integrating with the mousewheel.