Revert "Fix unit tests native dependencies" #10919
Merged
+1
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2ff7cad.
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10919 +/- ##
=================================================
- Coverage 2.98812% 2.98754% -0.00058%
=================================================
Files 3320 3319 -1
Lines 664900 664894 -6
Branches 74675 74674 -1
=================================================
- Hits 19868 19864 -4
+ Misses 644851 644849 -2
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
harshit7962
approved these changes
Jun 9, 2025
|
Thank you for the follow-up @ThomasGoulet73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 2ff7cad (#10338). The linked issue (dotnet/runtime#111825) was closed when the fix (dotnet/runtime#114651) was merged in the runtime. The fix flowed in this repo and I'm no longer able to reproduce it locally.
Customer Impact
None, tests only.
Regression
No.
Testing
Ran the tests locally and tested the initial test I used when I pushed the workaround.
Risk
Low to none, tests only.
Microsoft Reviewers: Open in CodeFlow