Reapply "Don't use incompatible LOAD_LIBRARY_SEARCH flags when using LOAD_WITH_ALTERED_SEARCH_PATH" #114651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LOAD_WITH…" (dotnet#114592) This reverts commit 8f313fd.
elinor-fung
requested review from
thaystg,
steveisok,
vitek-karas and
MichalStrehovsky
as code owners
ghost
added
the
There was a problem hiding this comment.
Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (3)
- src/tests/Interop/CMakeLists.txt: Language not supported
- src/tests/Interop/DllImportSearchPaths/DllImportSearchPathsTest.csproj: Language not supported
- src/tests/Interop/DllImportSearchPaths/NativeLibraryWithDependency/CMakeLists.txt: Language not supported
|
Tagging subscribers to this area: @dotnet/interop-contrib |
AaronRobinsonMSFT
approved these changes
Apr 14, 2025
This was referenced Apr 14, 2025
This was referenced Apr 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undo the revert in #114592.
49a21cb removes setting
/DEPENDENTLOADFLAG:0x800per #111990 (comment) - fixes #114595fc4dbe2 ignores empty paths when looking in the p/invoke assembly directory - fixes #114594
c035fdf adds a test in
DllImportSearchPathsTeststhat uses an in-memory assembly - would have found #114594Fixes #111825