-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix flaky test failures on x86 leg #10591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to address flaky test failures on the x86 leg by modifying the pipeline conditions for running xUnit tests.
- Updated the platform condition to restrict test execution only to x64 builds.
Comments suppressed due to low confidence (1)
eng/pipeline.yml:170
- The updated condition restricts test execution to only when _Platform is 'x64'. If the intention was to fix flaky failures on the x86 leg, confirm that this condition correctly targets the desired platform or revise it to include the proper platform specification.
condition: and(or(ne(variables['_HelixPipeline'], 'true'), and(eq(variables['_HelixPipeline'], 'true') ,eq(variables['_BuildConfig'], 'Release'), eq(variables['_PublicBuildPipeline'], 'true'), eq(variables['_ContinuousIntegrationTestsEnabled'], 'true'))), eq(variables['_Platform'], 'x64'))
@ViktorHofer Regarding the build failures mentioned due to flaky xunit tests, proposing this change to run the xunit tests only on x64. This appears due to the x64 forcing. |
You have platform specific assemblies in wpf, right? I assume that with this change, the x86 and arm64 artifacts won't get tested anymore? |
AFAIK, the current unit tests aren't testing those platforms specific assemblies. |
tests in official pipelines disturb insertion in windowsdesktop and sdk.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10591 +/- ##
===================================================
- Coverage 11.55761% 11.39785% -0.15977%
===================================================
Files 3214 3214
Lines 648508 648508
Branches 71511 71511
===================================================
- Hits 74952 73916 -1036
- Misses 572395 573435 +1040
+ Partials 1161 1157 -4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Please backport this into the 10.0 Preview 3 branch and also consider enabling pipeline notifications for future official build failures. |
/backport to release/10.0-preview3 |
Started backporting to release/10.0-preview3: https://github.com/dotnet/wpf/actions/runs/13926870389 |
Fix flaky test failures on x86 leg
disable tests in official pipeline
tests in official pipelines disturb insertion in windowsdesktop and sdk.
Microsoft Reviewers: Open in CodeFlow