Skip to content

Fix flaky test failures on x86 leg #10591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Fix flaky test failures on x86 leg #10591

merged 2 commits into from
Mar 18, 2025

Conversation

singhashish-wpf
Copy link
Member

@singhashish-wpf singhashish-wpf commented Mar 18, 2025

Fix flaky test failures on x86 leg
disable tests in official pipeline
tests in official pipelines disturb insertion in windowsdesktop and sdk.

Microsoft Reviewers: Open in CodeFlow

@Copilot Copilot AI review requested due to automatic review settings March 18, 2025 10:59
@singhashish-wpf singhashish-wpf requested review from a team as code owners March 18, 2025 10:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to address flaky test failures on the x86 leg by modifying the pipeline conditions for running xUnit tests.

  • Updated the platform condition to restrict test execution only to x64 builds.
Comments suppressed due to low confidence (1)

eng/pipeline.yml:170

  • The updated condition restricts test execution to only when _Platform is 'x64'. If the intention was to fix flaky failures on the x86 leg, confirm that this condition correctly targets the desired platform or revise it to include the proper platform specification.
condition: and(or(ne(variables['_HelixPipeline'], 'true'), and(eq(variables['_HelixPipeline'], 'true') ,eq(variables['_BuildConfig'], 'Release'), eq(variables['_PublicBuildPipeline'], 'true'), eq(variables['_ContinuousIntegrationTestsEnabled'], 'true'))), eq(variables['_Platform'], 'x64'))

@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Mar 18, 2025
@singhashish-wpf
Copy link
Member Author

singhashish-wpf commented Mar 18, 2025

@ViktorHofer Regarding the build failures mentioned due to flaky xunit tests, proposing this change to run the xunit tests only on x64. This appears due to the x64 forcing.
I observed that the test failures are in x86 leg only on the official pipeline. Let me know if I am missing something here.

@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 18, 2025

You have platform specific assemblies in wpf, right? I assume that with this change, the x86 and arm64 artifacts won't get tested anymore?

@singhashish-wpf
Copy link
Member Author

You have platform specific assemblies in wpf, right? I assume that with this change, the x86 and arm64 artifacts won't get tested anymore?

AFAIK, the current unit tests aren't testing those platforms specific assemblies.

tests in official pipelines disturb insertion in windowsdesktop and sdk.
@singhashish-wpf singhashish-wpf added the auto_merge bot-command label Mar 18, 2025
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.39785%. Comparing base (8f9956b) to head (c92bcf2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10591         +/-   ##
===================================================
- Coverage   11.55761%   11.39785%   -0.15977%     
===================================================
  Files           3214        3214                 
  Lines         648508      648508                 
  Branches       71511       71511                 
===================================================
- Hits           74952       73916       -1036     
- Misses        572395      573435       +1040     
+ Partials        1161        1157          -4     
Flag Coverage Δ
Debug 11.39785% <ø> (-0.05612%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pchaurasia14 pchaurasia14 merged commit f9683f8 into main Mar 18, 2025
8 checks passed
@pchaurasia14 pchaurasia14 deleted the singhashish-wpf-patch-2 branch March 18, 2025 11:44
@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 18, 2025

Please backport this into the 10.0 Preview 3 branch and also consider enabling pipeline notifications for future official build failures.

@singhashish-wpf
Copy link
Member Author

/backport to release/10.0-preview3

Copy link

Started backporting to release/10.0-preview3: https://github.com/dotnet/wpf/actions/runs/13926870389

@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto_merge bot-command PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants