Skip to content

Suppress SYSLIB5005 for System.Formats.Nrbf as experimental #12156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Suppress SYSLIB5005 for System.Formats.Nrbf as experimental #12156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/System.Private.Windows.Core/src/System.Private.Windows.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,12 @@
users won't be impacted. If some name becomes difficult to adapt to with the @ symbol we can
cross that bridge when we hit it (if ever).
-->
<NoWarn>$(NoWarn);CS8981;CS3016</NoWarn>
<NoWarn>$(NoWarn);CS8981</NoWarn>
<!--
We don't care about CLS compliance since everything here is internal and we want to match native types.
CS3016: We don't care about CLS compliance since everything here is internal and we want to match native types.
SYSLIB5005: System.Formats.Nrbf is experimental
-->
<NoWarn>$(NoWarn);CS3016</NoWarn>
<NoWarn>$(NoWarn);CS3016;SYSLIB5005</NoWarn>
<Deterministic>true</Deterministic>
<ProduceReferenceAssembly>true</ProduceReferenceAssembly>
<UsePublicApiAnalyzers>false</UsePublicApiAnalyzers>
Expand Down
3 changes: 2 additions & 1 deletion src/System.Private.Windows.Core/tests/BinaryFormatTests/BinaryFormatTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@
SYSLIB0011: BinaryFormatter obsolete
SYSLIB0050: Obsolete attribute
SYSLIB0051: Formatters obsolete
SYSLIB5005: System.Formats.Nrbf is experimental
-->
<NoWarn>$(NoWarn);CS1574;CS1580;CA1036;CA1051;CA1066;SYSLIB0011;SYSLIB0050;SYSLIB0051;xUnit1013</NoWarn>
<NoWarn>$(NoWarn);CS1574;CS1580;CA1036;CA1051;CA1066;SYSLIB0011;SYSLIB0050;SYSLIB0051;SYSLIB5005;xUnit1013</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
4 changes: 4 additions & 0 deletions ...Forms.Primitives/tests/TestUtilities/System.Windows.Forms.Primitives.TestUtilities.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
<AssemblyName>System.Windows.Forms.Primitives.TestUtilities</AssemblyName>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<RootNamespace>System</RootNamespace>
<!--
SYSLIB5005: System.Formats.Nrbf is experimental
-->
<NoWarn>$(NoWarn);SYSLIB5005</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
4 changes: 4 additions & 0 deletions src/System.Windows.Forms/src/System.Windows.Forms.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
See https://github.com/dotnet/winforms/issues/4649
-->
<NoWarn>$(NoWarn);IL2026;IL2050;IL2057;IL2062;IL2067;IL2070;IL2072;IL2075;IL2077;IL2080;IL2092;IL2093;IL2094;IL2096;IL2111;IL2055</NoWarn>
<!--
SYSLIB5005: System.Formats.Nrbf is experimental
-->
<NoWarn>$(NoWarn);SYSLIB5005</NoWarn>
<Win32Manifest>Resources\System\Windows\Forms\XPThemes.manifest</Win32Manifest>
<Deterministic>true</Deterministic>
<ProduceReferenceAssembly>true</ProduceReferenceAssembly>
Expand Down
7 changes: 6 additions & 1 deletion src/System.Windows.Forms/tests/UnitTests/System.Windows.Forms.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@
</PropertyGroup>

<PropertyGroup>
<NoWarn>$(NoWarn),1573,1591,1712,WFDEV001,SYSLIB0050,SYSLIB0051;</NoWarn>
<!--
SYSLIB0050: Formatter-based serialization is obsolete and should not be used
SYSLIB0051: This API supports obsolete formatter-based serialization
SYSLIB5005: System.Formats.Nrbf is experimental
-->
<NoWarn>$(NoWarn),1573,1591,1712,WFDEV001,SYSLIB0050,SYSLIB0051,SYSLIB5005</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
Loading