-
Notifications
You must be signed in to change notification settings - Fork 1k
Suppress SYSLIB5005 for System.Formats.Nrbf as experimental #12156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress SYSLIB5005 for System.Formats.Nrbf as experimental #12156
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12156 +/- ##
===================================================
- Coverage 75.26502% 75.26076% -0.00427%
===================================================
Files 3085 3085
Lines 633629 633629
Branches 46839 46839
===================================================
- Hits 476901 476874 -27
- Misses 153330 153341 +11
- Partials 3398 3414 +16
Flags with carried forward coverage won't be shown. Click here to find out more. |
/backport to release/9.0 |
Started backporting to release/9.0: https://github.com/dotnet/winforms/actions/runs/10908125931 |
/backport to release/9.0-rc2 |
Started backporting to release/9.0-rc2: https://github.com/dotnet/winforms/actions/runs/10908136459 |
@jeffhandley - is there a workitem to track removing |
@Tanya-Solyanik No, we don't have a tracking item for that. We'll monitor adoption and feedback on the APIs and evaluate during .NET 10 if we've reached a high enough degree of confidence to remove it before .NET 10 hits GA. |
With dotnet/runtime#107905, we are marking
System.Formats.Nrbf
as[Experimental]
, using diagnostic IDSYSLIB5005
. This suppresses the diagnostics produced by that annotation.We plan to backport this change to
release/9.0
andrelease/9.0-rc2
.Microsoft Reviewers: Open in CodeFlow