Skip to content

Suppress SYSLIB5005 for System.Formats.Nrbf as experimental #12156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

jeffhandley
Copy link
Member

@jeffhandley jeffhandley commented Sep 17, 2024

With dotnet/runtime#107905, we are marking System.Formats.Nrbf as [Experimental], using diagnostic ID SYSLIB5005. This suppresses the diagnostics produced by that annotation.

We plan to backport this change to release/9.0 and release/9.0-rc2.

Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.26076%. Comparing base (d174e80) to head (044c77f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12156         +/-   ##
===================================================
- Coverage   75.26502%   75.26076%   -0.00427%     
===================================================
  Files           3085        3085                 
  Lines         633629      633629                 
  Branches       46839       46839                 
===================================================
- Hits          476901      476874         -27     
- Misses        153330      153341         +11     
- Partials        3398        3414         +16     
Flag Coverage Δ
Debug 75.26076% <ø> (-0.00427%) ⬇️
integration 18.01604% <ø> (+0.00035%) ⬆️
production 48.56189% <ø> (-0.00949%) ⬇️
test 97.02282% <ø> (ø)
unit 45.60027% <ø> (+0.02004%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lonitra lonitra enabled auto-merge (squash) September 17, 2024 17:09
@lonitra lonitra merged commit 5989ece into dotnet:main Sep 17, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Sep 17, 2024
@lonitra
Copy link
Member

lonitra commented Sep 17, 2024

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/winforms/actions/runs/10908125931

@lonitra
Copy link
Member

lonitra commented Sep 17, 2024

/backport to release/9.0-rc2

Copy link
Contributor

Started backporting to release/9.0-rc2: https://github.com/dotnet/winforms/actions/runs/10908136459

@Tanya-Solyanik
Copy link
Contributor

Tanya-Solyanik commented Sep 18, 2024

@jeffhandley - is there a workitem to track removing experimental from this assembly?

@jeffhandley
Copy link
Member Author

@Tanya-Solyanik No, we don't have a tracking item for that. We'll monitor adoption and feedback on the APIs and evaluate during .NET 10 if we've reached a high enough degree of confidence to remove it before .NET 10 hits GA.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants