Ide0100 reaction

global.json

@@ -1,6 +1,6 @@
 {
   "tools": {
-    "dotnet": "9.0.100-preview.1.24101.2",
+    "dotnet": "9.0.100-preview.4.24176.15",
     "runtimes": {
       "dotnet/x64": [
         "$(VSRedistCommonNetCoreSharedFrameworkx6490PackageVersion)"
@@ -11,7 +11,7 @@
     }
   },
   "sdk": {
-    "version": "9.0.100-preview.1.24101.2"
+    "version": "9.0.100-preview.4.24176.15"
   },
   "msbuild-sdks": {
     "Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.24175.6",

src/System.Windows.Forms.Design/src/System/ComponentModel/Design/DesignerActionUI.cs

@@ -573,7 +573,7 @@ private void ToolStripDropDown_Closing(object? sender, ToolStripDropDownClosingE
             e.Cancel = false;
         }
 
-        if (e.Cancel == false)
+        if (!e.Cancel)
         {
             // We WILL disappear
             Debug.Assert(_lastPanelComponent is not null, "last panel component should not be null here... " +

src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/CommandSet.cs

@@ -1412,7 +1412,7 @@ protected void OnMenuCopy(object? sender, EventArgs e)
                 stream.Seek(0, SeekOrigin.Begin);
                 byte[] bytes = stream.GetBuffer();
                 IDataObject dataObj = new DataObject(CF_DESIGNER, bytes);
-                if (ExecuteSafely(() => Clipboard.SetDataObject(dataObj), throwOnException: false) == false)
+                if (!ExecuteSafely(() => Clipboard.SetDataObject(dataObj), throwOnException: false))
                 {
                     _uiService?.ShowError(SR.ClipboardError);
                 }

src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DataGridViewDesigner.cs

@@ -328,7 +328,7 @@ private void dataGridView_ColumnRemoved(object? sender, DataGridViewColumnEventA
         // of the column collection but there is no event there and we are restricted from adding any
         // Note: this does not break Undo/Redo because Undo/Redo uses serialization the same way
         // the build does and DisplayIndex is not serialized
-        if (e.Column is not null && e.Column.IsDataBound == false)
+        if (e.Column is not null && !e.Column.IsDataBound)
             e.Column.DisplayIndex = -1;
     }
 

src/System.Windows.Forms/src/System/Windows/Forms/Application.ComponentThreadContext.cs

@@ -235,7 +235,7 @@ internal override void TrackInput(bool track)
             // fine if it is an external manager, because it has already pushed a loop.
             if (ComponentManager is not null && _externalComponentManager)
             {
-                if (mustBeActive == false)
+                if (!mustBeActive)
                 {
                     return true;
                 }

src/System.Windows.Forms/src/System/Windows/Forms/Control.cs

@@ -3748,7 +3748,7 @@ private unsafe void WaitForWaitHandle(WaitHandle waitHandle)
             // If we didn't find the thread, or if GetExitCodeThread failed, we don't know the thread's state:
             // if we don't know, we shouldn't throw.
             if ((returnValue && exitCode != NTSTATUS.STILL_ACTIVE)
-                || (returnValue == false && Marshal.GetLastWin32Error() == (int)WIN32_ERROR.ERROR_INVALID_HANDLE)
+                || (!returnValue && Marshal.GetLastWin32Error() == (int)WIN32_ERROR.ERROR_INVALID_HANDLE)
                 || AppDomain.CurrentDomain.IsFinalizingForUnload())
             {
                 if (waitHandle.WaitOne(1, false))

src/System.Windows.Forms/src/System/Windows/Forms/Controls/ComboBox/ComboBox.cs

@@ -3779,7 +3779,7 @@ protected override unsafe void WndProc(ref Message m)
                     // WM_MOUSELEAVE to ourselves, since that also sets up the right state. Or... at least the state is the same
                     // as with Theming on.
 
-                    if (!Application.RenderWithVisualStyles && GetStyle(ControlStyles.UserPaint) == false
+                    if (!Application.RenderWithVisualStyles && !GetStyle(ControlStyles.UserPaint)
                         && DropDownStyle == ComboBoxStyle.DropDownList
                         && (FlatStyle == FlatStyle.Flat || FlatStyle == FlatStyle.Popup))
                     {

src/System.Windows.Forms/src/System/Windows/Forms/Controls/DataGridView/DataGridView.Methods.cs

@@ -10925,7 +10925,7 @@ private void MoveRowHeadersOrColumnResize(int x)
 
     public virtual void NotifyCurrentCellDirty(bool dirty)
     {
-        if (_dataGridViewState1[State1_IgnoringEditingChanges] == false)
+        if (!_dataGridViewState1[State1_IgnoringEditingChanges])
         {
             // autosizing has no effect since edited value hasn't been committed
             // and autosizing code only looks at committed values.

src/System.Windows.Forms/src/System/Windows/Forms/Controls/DataGridView/DataGridView.cs

@@ -3106,7 +3106,7 @@ public bool ReadOnly
                 Debug.Assert(_individualReadOnlyCells.Count == 0);
                 for (int columnIndex = 0; columnIndex < Columns.Count; columnIndex++)
                 {
-                    Debug.Assert(Columns[columnIndex].ReadOnly == false);
+                    Debug.Assert(!Columns[columnIndex].ReadOnly);
                 }
 
                 int rowCount = Rows.Count;

src/System.Windows.Forms/src/System/Windows/Forms/Controls/DataGridView/DataGridViewCheckBoxColumn.cs

@@ -224,7 +224,7 @@ public bool ThreeState
                 DataGridView.InvalidateColumn(Index);
             }
 
-            if (value && DefaultCellStyle.NullValue is bool boolValue && boolValue == false)
+            if (value && DefaultCellStyle.NullValue is bool boolValue && !boolValue)
             {
                 DefaultCellStyle.NullValue = CheckState.Indeterminate;
             }

src/System.Windows.Forms/src/System/Windows/Forms/Controls/GroupBox/GroupBox.cs

@@ -424,7 +424,7 @@ protected override void OnPaint(PaintEventArgs e)
             // We only pass in the text color if it is explicitly set, else we let the renderer use the color
             // specified by the theme. This is a temporary workaround till we find a good solution for the
             // "default theme color" issue.
-            if (ShouldSerializeForeColor() || Enabled == false)
+            if (ShouldSerializeForeColor() || !Enabled)
             {
                 Color textcolor = Enabled ? ForeColor : TextRenderer.DisabledTextColor(BackColor);
                 GroupBoxRenderer.DrawGroupBox(

src/System.Windows.Forms/src/System/Windows/Forms/Controls/ListBoxes/ListBox.cs

@@ -430,7 +430,7 @@ public override Font Font
         {
             base.Font = value;
 
-            if (_integralHeight == false)
+            if (!_integralHeight)
             {
                 // Refresh the list to force the scroll bars to display
                 // when the integral height is false.

src/System.Windows.Forms/src/System/Windows/Forms/Controls/ListView/ListViewGroup.cs

@@ -75,7 +75,7 @@ public ListViewGroup(string? header, HorizontalAlignment headerAlignment) : this
     }
 
     internal AccessibleObject AccessibilityObject
-        => _accessibilityObject ??= new ListViewGroupAccessibleObject(this, ListView?.Groups.Contains(this) == false);
+        => _accessibilityObject ??= new ListViewGroupAccessibleObject(this, !ListView?.Groups.Contains(this));
 
     /// <summary>
     ///  The text displayed in the group header.

src/System.Windows.Forms/src/System/Windows/Forms/Controls/ListView/ListViewItem.cs

@@ -867,7 +867,7 @@ public void BeginEdit()
         if (Index >= 0)
         {
             ListView lv = ListView!;
-            if (lv.LabelEdit == false)
+            if (!lv.LabelEdit)
             {
                 throw new InvalidOperationException(SR.ListViewBeginEditFailed);
             }

src/System.Windows.Forms/src/System/Windows/Forms/Controls/PropertyGrid/PropertyGridInternal/GridEntry.GridEntryAccessibleObject.cs

@@ -315,7 +315,7 @@ internal override void Collapse()
 
         internal override void Expand()
         {
-            if (this.TryGetOwnerAs(out GridEntry? owner) && owner.Expandable && owner.Expanded == false)
+            if (this.TryGetOwnerAs(out GridEntry? owner) && owner.Expandable && !owner.Expanded)
             {
                 owner.Expanded = true;
             }

src/System.Windows.Forms/src/System/Windows/Forms/Controls/PropertyGrid/PropertyGridInternal/PropertyGridView.GridViewTextBox.cs

@@ -274,7 +274,7 @@ protected override bool ProcessDialogKey(Keys keyData)
         protected override void SetVisibleCore(bool value)
         {
             // Make sure we don't have the mouse captured if we're going invisible.
-            if (value == false && HookMouseDown)
+            if (!value && HookMouseDown)
             {
                 _mouseHook.HookMouseDown = false;
             }

src/System.Windows.Forms/src/System/Windows/Forms/Controls/RichTextBox/RichTextBox.cs

@@ -2593,7 +2593,7 @@ public void Paste(DataFormats.Format clipFormat)
 
     protected override bool ProcessCmdKey(ref Message m, Keys keyData)
     {
-        if (RichTextShortcutsEnabled == false)
+        if (!RichTextShortcutsEnabled)
         {
             foreach (int shortcutValue in s_shortcutsToDisable!)
             {

src/System.Windows.Forms/src/System/Windows/Forms/Controls/TabControl/TabControl.cs

@@ -557,7 +557,7 @@ public bool Multiline
             if (Multiline != value)
             {
                 SetState(State.Multiline, value);
-                if (Multiline == false && (_alignment == TabAlignment.Left || _alignment == TabAlignment.Right))
+                if (!Multiline && (_alignment == TabAlignment.Left || _alignment == TabAlignment.Right))
                 {
                     _alignment = TabAlignment.Top;
                 }

src/System.Windows.Forms/src/System/Windows/Forms/Controls/TextBox/MaskedTextBox.cs

@@ -2321,7 +2321,7 @@ private void PasteInt(string? text)
         {
             string? message = null;
 
-            if (!_flagState[s_isNullMask] && _maskedTextProvider.MaskCompleted == false)
+            if (!_flagState[s_isNullMask] && !_maskedTextProvider.MaskCompleted)
             {
                 message = SR.MaskedTextBoxIncompleteMsg;
             }

src/System.Windows.Forms/src/System/Windows/Forms/Controls/TextBox/TextBoxBase.cs

@@ -175,7 +175,7 @@ protected override bool ProcessCmdKey(ref Message msg, Keys keyData)
         // the shortcut key we are not supported in TextBox.
         bool returnedValue = base.ProcessCmdKey(ref msg, keyData);
 
-        if (ShortcutsEnabled == false && s_shortcutsToDisable is not null)
+        if (!ShortcutsEnabled && s_shortcutsToDisable is not null)
         {
             foreach (int shortcutValue in s_shortcutsToDisable)
             {

src/System.Windows.Forms/src/System/Windows/Forms/Controls/ToolStrips/ToolStrip.cs

@@ -431,7 +431,7 @@ internal bool CanHotTrack
             if (!Focused)
             {
                 // if  ContainsFocus in one of the children = false, someone is just mousing by, we can hot track
-                return (ContainsFocus == false);
+                return !ContainsFocus;
             }
             else
             {

src/System.Windows.Forms/src/System/Windows/Forms/Controls/ToolStrips/ToolStripDropDown.cs

@@ -2012,7 +2012,7 @@ private void ShowCore()
 
     private bool ShouldSerializeDropShadowEnabled()
     {
-        return _dropShadowEnabled == false;
+        return !_dropShadowEnabled;
     }
 
     internal override bool ShouldSerializeLayoutStyle()

src/System.Windows.Forms/src/System/Windows/Forms/Controls/ToolStrips/ToolStripManager.ModalMenuFilter.cs

@@ -406,7 +406,7 @@ private void SetActiveToolStripCore(ToolStrip toolStrip)
                 // For something that never closes, don't use menu mode.
                 ToolStripDropDown dropDown = (ToolStripDropDown)toolStrip;
 
-                if (dropDown.AutoClose == false)
+                if (!dropDown.AutoClose)
                 {
                     // Store off the current active hwnd
                     HWND hwndActive = PInvoke.GetActiveWindow();

src/System.Windows.Forms/src/System/Windows/Forms/Controls/ToolStrips/ToolStripManager.cs

@@ -188,7 +188,7 @@ private static bool CanChangeSelection(ToolStrip start, ToolStrip toolStrip)
             return false;
         }
 
-        bool canChange = toolStrip.TabStop == false &&
+        bool canChange = !toolStrip.TabStop &&
                              toolStrip.Enabled &&
                              toolStrip.Visible &&
                              !toolStrip.IsDisposed &&

src/System.Windows.Forms/src/System/Windows/Forms/Controls/ToolStrips/ToolStripSplitButton.cs

@@ -167,7 +167,7 @@ public event EventHandler? DefaultItemChanged
         remove => Events.RemoveHandler(s_eventDefaultItemChanged, value);
     }
 
-    protected internal override bool DismissWhenClicked => DropDown.Visible != true;
+    protected internal override bool DismissWhenClicked => !DropDown.Visible;
 
     internal override Rectangle DropDownButtonArea => DropDownButtonBounds;
 

src/System.Windows.Forms/src/System/Windows/Forms/Controls/ToolStrips/ToolStripSplitStackLayout.cs

@@ -593,7 +593,7 @@ private int SendNextItemToOverflow(int spaceNeeded, bool horizontal)
 
                 // send the item to the overflow.
                 item.SetPlacement(ToolStripItemPlacement.Overflow);
-                if (OverflowRequired == false)
+                if (!OverflowRequired)
                 {
                     // this is the first item we're sending down.
                     // we now need to account for the width or height of the overflow button

src/System.Windows.Forms/src/System/Windows/Forms/Controls/TreeView/TreeNode.cs

@@ -1276,7 +1276,7 @@ public void BeginEdit()
         if (HTREEITEMInternal != IntPtr.Zero)
         {
             TreeView tv = TreeView!;
-            if (tv.LabelEdit == false)
+            if (!tv.LabelEdit)
             {
                 throw new InvalidOperationException(SR.TreeNodeBeginEditFailed);
             }

src/System.Windows.Forms/src/System/Windows/Forms/Controls/UpDown/NumericUpDown.cs

@@ -745,7 +745,7 @@ protected override void UpdateEditText()
                          "DecimalValue lies outside of [minimum, maximum]");
 
             Text = GetNumberText(_currentValue);
-            Debug.Assert(ChangingText == false, "ChangingText should have been set to false");
+            Debug.Assert(!ChangingText, "ChangingText should have been set to false");
         }
     }
 

src/System.Windows.Forms/src/System/Windows/Forms/Controls/UpDown/UpDownBase.cs

@@ -646,7 +646,7 @@ protected virtual void OnTextBoxTextChanged(object? source, EventArgs e)
     {
         if (ChangingText)
         {
-            Debug.Assert(UserEdit == false, "OnTextBoxTextChanged() - UserEdit == true");
+            Debug.Assert(!UserEdit, "OnTextBoxTextChanged() - UserEdit == true");
             ChangingText = false;
         }
         else

src/System.Windows.Forms/src/System/Windows/Forms/DataBinding/Binding.cs

@@ -934,7 +934,7 @@ internal bool PullData(bool reformat, bool force)
             // on this binding because we know the value in the control was valid and has been accepted by
             // the data source. But if the operation failed (or was cancelled), we must leave the dirty flag
             // alone, so that the control's value will continue to be re-validated and re-pulled later.
-            if (args.BindingCompleteState == BindingCompleteState.Success && args.Cancel == false)
+            if (args.BindingCompleteState == BindingCompleteState.Success && !args.Cancel)
             {
                 _state.ChangeFlags(BindingStates.Modified, false);
             }

src/System.Windows.Forms/src/System/Windows/Forms/Design/ComponentEditorForm.cs

@@ -102,7 +102,7 @@ internal virtual void ApplyChanges(bool lastApply)
         _cancelButton.Text = SR.CloseCaption;
         _dirty = false;
 
-        if (lastApply == false)
+        if (!lastApply)
         {
             for (int n = 0; n < _pageSites.Length; n++)
             {

src/System.Windows.Forms/src/System/Windows/Forms/Form.cs

@@ -6406,7 +6406,7 @@ private void WmNCDestroy(ref Message m)
 
         if (Modal && _dialogResult == DialogResult.None)
         {
-            if (GetState(States.Recreate) == false)
+            if (!GetState(States.Recreate))
             {
                 DialogResult = DialogResult.Cancel;
             }

src/System.Windows.Forms/src/System/Windows/Forms/Layout/CommonProperties.cs

@@ -191,7 +191,7 @@ internal static void SetAutoSize(IArrangedElement element, bool value)
         BitVector32 state = GetLayoutState(element);
         state[s_autoSizeSection] = value ? 1 : 0;
         SetLayoutState(element, state);
-        if (value == false)
+        if (!value)
         {
             // If autoSize is being turned off, restore the control to its specified bounds.
             element.SetBounds(GetSpecifiedBounds(element), BoundsSpecified.None);