Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ide0100 reaction #11131

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Ide0100 reaction #11131

merged 4 commits into from
Mar 27, 2024

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Mar 27, 2024

293cc09 by far wasn't enough.

  1. Commit: Update code for IDE0100 improved diagnostics
  2. Commit: Temporarily update SDK (will revert before merging)

akoeplinger
akoeplinger previously approved these changes Mar 27, 2024
akoeplinger
akoeplinger previously approved these changes Mar 27, 2024
@ViktorHofer ViktorHofer merged commit bd0e298 into dotnet:main Mar 27, 2024
8 checks passed
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 45.16129% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 73.39457%. Comparing base (9c9b2e0) to head (e0ba786).
Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11131         +/-   ##
===================================================
+ Coverage   73.39203%   73.39457%   +0.00253%     
===================================================
  Files           3097        3097                 
  Lines         632134      632134                 
  Branches       46650       46650                 
===================================================
+ Hits          463936      463952         +16     
+ Misses        164802      164789         -13     
+ Partials        3396        3393          -3     
Flag Coverage Δ
Debug 73.39457% <45.16129%> (+0.00253%) ⬆️
integration 18.19317% <16.12903%> (-0.01629%) ⬇️
production 46.80632% <45.16129%> (+0.00563%) ⬆️
test 94.98267% <ø> (ø)
unit 43.85995% <45.16129%> (-0.02048%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview4 milestone Mar 27, 2024
@ViktorHofer ViktorHofer deleted the IDE0100Reaction branch March 27, 2024 08:18
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants