Conversation
partially addresses dotnet/templating dotnet#2456 updates to readme.md: - removed invalid steps in debugging - updated how to run dotnet 3 - updated how to install the packages - updated solution name
bekir-ozturk
left a comment
bekir-ozturk
left a comment
There was a problem hiding this comment.
A few minor comments. Thank you.
AR-May
left a comment
AR-May
left a comment
There was a problem hiding this comment.
LGTM. The only thing is the 'dotnet new3' command, which does not work currently because of a bug.
We can either go with 'dotnet .\dotnet-new3.dll' everywhere in this file and fix readme after we fix the bug. Or we may write the workaround for the bug in one place and continue to use 'dotnet new3' everywhere else. Both options is fine for me.
| - When running the build script, the existing built-in command `dotnet new` will be preserved. A new command `dotnet new3` will be enabled which allows you to create | ||
| files with the latest Template Engine. | ||
| - That's it! Now you can run `dotnet new3`. | ||
| - When running the build script, the existing built-in command `dotnet new` will be preserved. To run `dotnet new3`, run `dotnet <your repo location>\artifacts\bin\dotnet-new3\Debug\netcoreapp2.1\dotnet-new3.dll` (root path to `dotnet-new3.dll` is skipped in all commands below). |
There was a problem hiding this comment.
This is a bug. It is supposed to work with 'dotnet new3'. We now have a workaround using the path to dotnet-new3.dll, but it should not be like that.
- We need to open an issue for fixing this.
- Maybe it is better to keep the previous version with 'dotnet new3' and just add this as a temporary workaround.
There was a problem hiding this comment.
Already created #2521 to track it. I'm not sure when we have time to fix it, so I suggest once it is fixed, update readme.md again. I'm updating issue description for that.
5 participants
fixes dotnet/templating #2455 dotnet/templating #1350
partially addresses dotnet/templating #2456
updates to readme.md: