Build MSBuild.SourceBuild.slnf (new solution filter) #1965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated so this PR is actually getting the version with the slnf file, but that might not be all it takes to fix it. |
dagood
requested changes
Jan 8, 2021
| @@ -52,7 +52,7 @@ | |||
| </Dependency> | |||
| <Dependency Name="Microsoft.Build" Version="16.8.0" CoherentParentDependency="Microsoft.Dotnet.Sdk.Internal"> | |||
| <Uri>https://github.com/dotnet/msbuild</Uri> | |||
| <Sha>126527ff107ae93fed10af675506c56d046aa5a3</Sha> | |||
| <Sha>c6ed2fef9d1cb5504eb51c6f6a9d529e4efd9054</Sha> | |||
There was a problem hiding this comment.
Probably shouldn't update our 5.0 release branch (source-build master) to a 6.0 commit (msbuild master). 😛
There was a problem hiding this comment.
MSBuild master is 16.9 is 5.0.200.
There was a problem hiding this comment.
Oh, interesting. We do only build 5.0.1xx, so the logic still applies, but thanks for the correction.
|
Triage: superseded by #2044. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/msbuild#6010 replaced
MSBuild.SourceBuild.slnwithMSBuild.SourceBuild.slnf. The subset of projects it's building stays the same.