Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace MSBuild.Dev.sln and MSBuild.SourceBuild.sln with solution filters #6010

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

ladipro
Copy link
Member

@ladipro ladipro commented Jan 5, 2021

Trivially replaced the two .sln's, which are a strict subset of MSBuild.sln, with .slnf's for easier maintenance.

Source build will likely need to be tweaked to build the new file.

@ladipro ladipro changed the title Replace MSBuild.Dev.sln and MSBuild.SourceBuild.sln with solution fil… Replace MSBuild.Dev.sln and MSBuild.SourceBuild.sln with solution filters Jan 5, 2021
@rainersigwald
Copy link
Member

For MSBuild.Dev.sln I'm completely on board. For sourcebuild, I'm worried that the version of MSBuild that we use to build ourselves in the initial run isn't new enough to support a solution filter. @dagood, do you know offhand what version that is?

@dagood
Copy link
Member

dagood commented Jan 6, 2021

I don't know how recently solution filters got in, but for context, source-build doesn't actually have to build a new version using a significantly older version. We'll build source-build 6.0.100 with a prebuilt copy of 6.0.100, then 6.0.101 builds using 6.0.100. Eventually we hope to be able to build e.g. 6.0.200 using 6.0.1XX (depends on having good enough infra for it to be feasible to maintain multiple feature bands), but that's the biggest type of gap we'd like people to keep in mind for now.

@rainersigwald
Copy link
Member

Ah, great! MSBuild's solution filter support was in 5.0.100 so we should be good.

Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ladipro ladipro merged commit c6ed2fe into dotnet:master Jan 8, 2021
@ladipro ladipro deleted the add-solution-filters branch January 8, 2021 10:44
@ladipro
Copy link
Member Author

ladipro commented Jan 8, 2021

Created dotnet/source-build#1965 to consume this change in source-build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants