Specify sdk version in global.json #509
Conversation
global.json
Outdated
| ".dotnet", | ||
| "$host$" | ||
| ], | ||
| "errorMessage": "The required .NET SDK wasn't found." |
There was a problem hiding this comment.
Curious why this is needed/beneficial over the default?
There was a problem hiding this comment.
This ensures that the builds are more consistent and portable across different machines. It prevents errors like what’s described in dotnet/source-build#5428 from occurring.
There was a problem hiding this comment.
I am specifically referring to the errorMessage. I ask because when I have seen this in the past, it typically contains something custom like "Please run ./eng/common/dotnet.cmd/sh to install it.". Doesn't the default message already convey the required SDK was not found?
There was a problem hiding this comment.
Gotcha. Those dotnet scripts don't exist in this branch (only 10.0+), so I think the default message is appropriate. Addressed in c95b757
Removed error message from global.json.
3 participants
Fixes dotnet/source-build#5428
This PR specifies the sdk version (patch roll forward enabled) in the global.json, ensuring the build uses the correct SDK version.
Previously, builds could pick up a newer .NET SDK if it was installed, leading to version mismatches and MSBuild errors. Pinning the SDK version in global.json resolves this.
Test pipeline run