Skip to content

Specify sdk version in global.json #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellahathaway merged 2 commits into from
Dec 2, 2025
Merged

Specify sdk version in global.json #509

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc38071
Specify sdk version in global.json
ellahathaway Dec 1, 2025
c95b757
Remove error message from global.json
ellahathaway Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ done

scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"

sdkLine=$(grep -m 1 'dotnet' "$scriptroot/global.json")
sdkLine=$(grep -m 1 '"dotnet"' "$scriptroot/global.json")
sdkPattern="\"dotnet\" *: *\"(.*)\""
if [[ $sdkLine =~ $sdkPattern ]]; then
export SDK_VERSION=${BASH_REMATCH[1]}
Expand Down
9 changes: 9 additions & 0 deletions global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
{
"sdk": {
"version": "9.0.112",
"rollForward": "latestPatch",
"paths": [
".dotnet",
"$host$"
],
"errorMessage": "The required .NET SDK wasn't found."
Copy link
Member

@MichaelSimons MichaelSimons Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why this is needed/beneficial over the default?

Copy link
Member Author

@ellahathaway ellahathaway Dec 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures that the builds are more consistent and portable across different machines. It prevents errors like what’s described in dotnet/source-build#5428 from occurring.

Copy link
Member

@MichaelSimons MichaelSimons Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am specifically referring to the errorMessage. I ask because when I have seen this in the past, it typically contains something custom like "Please run ./eng/common/dotnet.cmd/sh to install it.". Doesn't the default message already convey the required SDK was not found?

Copy link
Member Author

@ellahathaway ellahathaway Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. Those dotnet scripts don't exist in this branch (only 10.0+), so I think the default message is appropriate. Addressed in c95b757

},
"tools": {
"dotnet": "9.0.112"
},
Expand Down