Allow repos to opt-out of building tests

[NikolaMilosavljevic]

This is a prerequisite for us enabling tests in VMR, i.e. #44843

This PR sets the new opt-out property for repos that are not ready to build tests, for some reason. I will create issues for each of those repos with detailed info about test failures and steps forward. PRs with fixes would follow soon after.

This PR also fixes the issue with building tests in sdk repo.

I understand that the new property DoNotBuildTests has a very similar name to the property we use to enable tests: DotNetBuildTests. If there is a significant risk of confusion, we can change the name to something else.

[akoeplinger]

I understand that the new property DoNotBuildTests has a very similar name to the property we use to enable tests: DotNetBuildTests. If there is a significant risk of confusion, we can change the name to something else.

Yes please, I already had to read that sentence twice to spot the difference :D

I'd call it DotNetBuildTestsOptOut to match the existing DeterministicBuildOptOut.

[mthalman]

I do think the names are deceptively similar. I propose a name like ExcludeFromBuildingTests.

[ViktorHofer]

This doesn't need to be in a target. Only properties that need dynamic resolution (like the one above) needs to be here.

I would put this here:

sdk/src/SourceBuild/content/repo-projects/Directory.Build.targets

Line 40 in b24c716

</PropertyGroup>

[NikolaMilosavljevic]

Yeah, that's better - thanks!

[NikolaMilosavljevic]

Fixed with 51744b8

[ViktorHofer]

Should we file tracking issues for these exclusions and add comments here?

[NikolaMilosavljevic]

Sure. I'll do that - thanks!

[NikolaMilosavljevic]

Fixed with 51744b8

[NikolaMilosavljevic]

I understand that the new property DoNotBuildTests has a very similar name to the property we use to enable tests: DotNetBuildTests. If there is a significant risk of confusion, we can change the name to something else.

Yes please, I already had to read that sentence twice to spot the difference :D

I'd call it DotNetBuildTestsOptOut to match the existing DeterministicBuildOptOut.

Hmm, we have two naming proposals now: DotNetBuildTestsOptOut and ExcludeFromBuildingTests.

To me, ExcludeFromBuildingTests sounds better. However, we already have several OptOut-named properties, i.e. LogVerbosityOptOut and DeterministicBuildOptOut

[NikolaMilosavljevic]

I understand that the new property DoNotBuildTests has a very similar name to the property we use to enable tests: DotNetBuildTests. If there is a significant risk of confusion, we can change the name to something else.

Yes please, I already had to read that sentence twice to spot the difference :D
I'd call it DotNetBuildTestsOptOut to match the existing DeterministicBuildOptOut.

Hmm, we have two naming proposals now: DotNetBuildTestsOptOut and ExcludeFromBuildingTests.

To me, ExcludeFromBuildingTests sounds better. However, we already have several OptOut-named properties, i.e. LogVerbosityOptOut and DeterministicBuildOptOut

OK - going with DotNetBuildTestsOptOut - will update the PR soon.

[NikolaMilosavljevic]

I understand that the new property DoNotBuildTests has a very similar name to the property we use to enable tests: DotNetBuildTests. If there is a significant risk of confusion, we can change the name to something else.

Yes please, I already had to read that sentence twice to spot the difference :D

I'd call it DotNetBuildTestsOptOut to match the existing DeterministicBuildOptOut.

Fixed with 51744b8

[NikolaMilosavljevic]

All checks are passing except an unrelated TestBuild: macOS (arm64) which is getting cancelled after 150 minutes. This is happening in other PRs as well.