Skip to content

Commit 51744b8

Browse files
Address PR comment
1 parent b24c716 commit 51744b8

File tree

5 files changed

+14
-7
lines changed

5 files changed

+14
-7
lines changed

src/SourceBuild/content/repo-projects/Directory.Build.targets

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@
3737
<BuildArgs>$(BuildArgs) /p:PortableBuild=$(PortableBuild)</BuildArgs>
3838
<BuildArgs Condition="'$(ShortStack)' != 'true' and '$(TargetOS)' != 'linux-musl'">$(BuildArgs) /p:RuntimeOS=$(RuntimeOS)</BuildArgs>
3939
<BuildArgs Condition="'$(ShortStack)' != 'true' and '$(TargetOS)' != 'linux-musl'">$(BuildArgs) /p:BaseOS=$(BaseOS)</BuildArgs>
40+
41+
<!-- Only pass when enabled to reduce command line noise. -->
42+
<BuildArgs Condition="'$(DotNetBuildTests)' == 'true' and '$(DotNetBuildTestsOptOut)' != 'true'">$(BuildArgs) /p:DotNetBuildTests=true</BuildArgs>
4043
</PropertyGroup>
4144

4245
<PropertyGroup>
@@ -459,9 +462,6 @@
459462
ProcessFrameworkReferences not be able to restore for the given RID. -->
460463
<BuildArgs Condition="'$(DotNetBuildSourceOnly)' != 'true' and '@(TransitiveRepositoryReference->AnyHaveMetadataValue('Identity', 'runtime'))' == 'true'">$(BuildArgs) /p:DotNetBuildTargetRidOnly=true</BuildArgs>
461464

462-
<!-- Only pass when enabled to reduce command line noise. -->
463-
<BuildArgs Condition="'$(DotNetBuildTests)' == 'true' and '$(DoNotBuildTests)' != 'true'">$(BuildArgs) /p:DotNetBuildTests=true</BuildArgs>
464-
465465
<BuildCommand Condition="'$(BuildCommand)' == '' and '$(IsUtilityProject)' != 'true'">$(BuildScript) $(BuildActions) $(BuildArgs)</BuildCommand>
466466
</PropertyGroup>
467467
</Target>

src/SourceBuild/content/repo-projects/aspnetcore.proj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@
3030
<BuildArgs>$(BuildArgs) /p:EnablePackageValidation=false</BuildArgs>
3131

3232
<LogVerbosityOptOut>true</LogVerbosityOptOut>
33-
<DoNotBuildTests>true</DoNotBuildTests>
33+
34+
<!-- Tests are failing to build: https://github.com/dotnet/aspnetcore/issues/60095 -->
35+
<DotNetBuildTestsOptOut>true</DotNetBuildTestsOptOut>
3436
</PropertyGroup>
3537

3638
<PropertyGroup Condition="'$(DotNetBuildSourceOnly)' == 'true'">

src/SourceBuild/content/repo-projects/efcore.proj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<DoNotBuildTests>true</DoNotBuildTests>
4+
<!-- Tests are failing to build: https://github.com/dotnet/efcore/issues/35547 -->
5+
<DotNetBuildTestsOptOut>true</DotNetBuildTestsOptOut>
56
</PropertyGroup>
67

78
<ItemGroup>

src/SourceBuild/content/repo-projects/roslyn.proj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22

33
<PropertyGroup>
44
<LogVerbosityOptOut>true</LogVerbosityOptOut>
5-
<DoNotBuildTests>true</DoNotBuildTests>
5+
6+
<!-- Tests are failing to build: https://github.com/dotnet/roslyn/issues/76960 -->
7+
<DotNetBuildTestsOptOut>true</DotNetBuildTestsOptOut>
68

79
<!-- Roslyn's build.cmd adds -build automatically. On non-windows, use the default -->
810
<BuildActions Condition="'$(BuildOS)' == 'windows'">$(FlagParameterPrefix)restore</BuildActions>

src/SourceBuild/content/repo-projects/vstest.proj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22

33
<PropertyGroup>
44
<DeterministicBuildOptOut>true</DeterministicBuildOptOut>
5-
<DoNotBuildTests>true</DoNotBuildTests>
5+
6+
<!-- Tests are failing to build: https://github.com/microsoft/vstest/issues/14994 -->
7+
<DotNetBuildTestsOptOut>true</DotNetBuildTestsOptOut>
68
</PropertyGroup>
79

810
<ItemGroup>

0 commit comments

Comments
 (0)