[main] Update dependencies from dotnet/runtime #26715

dotnet-maestro · 2022-07-20T12:39:08Z

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
Build: 20220726.8
Date Produced: July 27, 2022 7:21:47 AM UTC
Commit: 2c31641b96d880dfb74d46fe63a91c8b35737cab
Branch: refs/heads/main

Updates:
- Microsoft.DotNet.ILCompiler: from 7.0.0-rc.1.22368.8 to 7.0.0-rc.1.22376.8
- Microsoft.Extensions.DependencyModel: from 7.0.0-rc.1.22368.8 to 7.0.0-rc.1.22376.8
- Microsoft.NET.HostModel: from 7.0.0-rc.1.22368.8 to 7.0.0-rc.1.22376.8
- Microsoft.NETCore.App.Host.win-x64: from 7.0.0-rc.1.22368.8 to 7.0.0-rc.1.22376.8
- Microsoft.NETCore.App.Ref: from 7.0.0-rc.1.22368.8 to 7.0.0-rc.1.22376.8
- Microsoft.NETCore.App.Runtime.win-x64: from 7.0.0-rc.1.22368.8 to 7.0.0-rc.1.22376.8
- Microsoft.NETCore.DotNetHostResolver: from 7.0.0-rc.1.22367.4 to 7.0.0-rc.1.22376.8
- Microsoft.NETCore.Platforms: from 7.0.0-rc.1.22368.8 to 7.0.0-rc.1.22376.8
- System.CodeDom: from 7.0.0-rc.1.22368.8 to 7.0.0-rc.1.22376.8
- System.Reflection.MetadataLoadContext: from 7.0.0-rc.1.22368.8 to 7.0.0-rc.1.22376.8
- System.Resources.Extensions: from 7.0.0-rc.1.22368.8 to 7.0.0-rc.1.22376.8
- System.Security.Cryptography.ProtectedData: from 7.0.0-rc.1.22368.8 to 7.0.0-rc.1.22376.8
- System.Text.Encoding.CodePages: from 7.0.0-rc.1.22368.8 to 7.0.0-rc.1.22376.8
- VS.Redist.Common.NetCore.SharedFramework.x64.7.0: from 7.0.0-rc.1.22368.8 to 7.0.0-rc.1.22376.8
- VS.Redist.Common.NetCore.TargetingPack.x64.7.0: from 7.0.0-rc.1.22368.8 to 7.0.0-rc.1.22376.8

…0719.9 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.1.22368.8 -> To Version 7.0.0-rc.1.22369.9

dotnet-maestro · 2022-07-20T12:44:15Z

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

kasperk81 · 2022-07-20T13:45:09Z

@jkoritzinsky failures from new analyzer dotnet/runtime@59eb554

  Restored /Users/runner/work/1/s/src/Tasks/Microsoft.NET.Build.Extensions.Tasks/Microsoft.NET.Build.Extensions.Tasks.csproj (in 412 ms).
  Restored /Users/runner/work/1/s/src/Tasks/Microsoft.NET.Build.Tasks/Microsoft.NET.Build.Tasks.csproj (in 508 ms).
  TelemetryStdOutLogger -> /Users/runner/work/1/s/artifacts/bin/Tests/TelemetryStdOutLogger/Release/net7.0/TelemetryStdOutLogger.dll
CSC : error AD0001: Analyzer 'Microsoft.Interop.Analyzers.CustomMarshallerAttributeAnalyzer' threw an exception of type 'System.InvalidOperationException' with message 'Sequence contains no elements'. [/Users/runner/work/1/s/src/Cli/Microsoft.DotNet.Cli.Utils/Microsoft.DotNet.Cli.Utils.csproj]
##[error]CSC(0,0): error AD0001: (NETCORE_ENGINEERING_TELEMETRY=Build) Analyzer 'Microsoft.Interop.Analyzers.CustomMarshallerAttributeAnalyzer' threw an exception of type 'System.InvalidOperationException' with message 'Sequence contains no elements'.

jkoritzinsky · 2022-07-20T14:42:41Z

I'll take a look when I get into the office

jkoritzinsky · 2022-07-20T17:30:15Z

Fix is in dotnet/runtime#72535

dotnet-maestro · 2022-07-20T19:45:29Z

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
For more details, please read the Arcade Darc documentation

…0721.1 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.1.22368.8 -> To Version 7.0.0-rc.1.22371.1

kasperk81 · 2022-07-21T13:18:14Z

dotnet/runtime@ddded2f is now included, ci is still failing here.

jkoritzinsky · 2022-07-21T15:05:18Z

Dang. I’ll try again. 😢

…0721.7 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.1.22368.8 -> To Version 7.0.0-rc.1.22371.7

…0722.9 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.1.22368.8 -> To Version 7.0.0-rc.1.22372.9

kasperk81 · 2022-07-24T01:56:01Z

next error:

/root/helix/work/correlation/d/sdk/7.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ILCompiler.targets(14,3): error MSB4019: The imported project "/root/helix/work/correlation/d/sdk/7.0.100-ci/Sdks/Microsoft.DotNet.ILCompiler/Sdk/Sdk.targets" was not found. Confirm that the expression in the Import declaration "/root/helix/work/correlation/d/sdk/7.0.100-ci/Sdks/Microsoft.DotNet.ILCompiler/Sdk/Sdk.targets" is correct, and that the file exists on disk. [/root/helix/work/workitem/e/testExecutionDirectory/ItCanNewResto---C3AFA90D_2/ItCanNewResto---C3AFA90D_2.csproj]

jkoritzinsky · 2022-07-24T03:16:56Z

cc: @dotnet/ilc-contrib for the next failure

…0723.4 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.1.22368.8 -> To Version 7.0.0-rc.1.22373.4

…0724.4 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.1.22368.8 -> To Version 7.0.0-rc.1.22374.4

LakshanF · 2022-07-25T15:09:46Z

Taking a look... PR #26780 from a change that was created earlier is getting validated.

LakshanF · 2022-07-25T19:27:48Z

PR, #26786, is attempting to fix the API typo error.

…0725.7 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.1.22368.8 -> To Version 7.0.0-rc.1.22375.7

LakshanF · 2022-07-26T18:43:35Z

The remaining failures are now in PackageInstall Tests and seem to be related to interop.

For example, GivenAnInstalledPackageUninstallRemovesThePackage has a build failure on my local machine with an interop call

Delegates with managed types as parameters or the return type require runtime marshalling to be enabled in the assembly where the delegate is defined. Microsoft.DotNet.NativeWrapper (net7.0) ..src\Resolvers\Microsoft.DotNet.NativeWrapper\Interop.cs 146 Active

@jkoritzinsky, is it possible to take a look and route this to the correct person please?

…0726.8 Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0 From Version 7.0.0-rc.1.22368.8 -> To Version 7.0.0-rc.1.22376.8

LakshanF · 2022-07-27T15:41:11Z

The package installer failures are passing in the new run (no test failures) and the new failure is due to a copy issue. This issue (given that all the tests pass) don't seem like a blocking issue

D:\a\1\s\src\RazorSdk\Sdk\Sdk.targets" to "D:\a\1\s\artifacts\bin\Release\Sdks\Microsoft.NET.Sdk.Razor\Sdk\Sdk.targets

kasperk81 · 2022-07-27T15:43:45Z

/p:PublishAot=true changes are not needed after the latest commit

LakshanF · 2022-07-27T15:55:31Z

/p:PublishAot=true changes are not needed after the latest commit

Can you clarify which commit please? The commit to work around a ILCompiler package issue ("Change tests to workaround #26791") is temporary and only impact the aot test but that is passing now. That test can be changed later after the merge and the issue, #26791 tracks that work.

kasperk81 · 2022-07-27T16:08:00Z

a82fd01 has your runtime change after which you do not need /p:PublishAot=true

since this pr is sitting waiting for more fixes, why not revert the outdated fixes which are not relevant anymore? it will save you from opening another pr

kasperk81 · 2022-07-27T18:39:08Z

Unhandled exception. System.InvalidOperationException: The collection has been marked as complete with regards to additions.
   at System.Collections.Concurrent.BlockingCollection`1.TryAddWithNoTimeValidation(T item, Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at System.Collections.Concurrent.BlockingCollection`1.Add(T item)
   at Microsoft.DotNet.Installer.Windows.TimestampedFileLogger.WriteMessage(String message) in /_/src/Cli/dotnet/Installer/Windows/TimestampedFileLogger.cs:line 187
   at Microsoft.DotNet.Installer.Windows.SetupLoggerBase.LogMessage(String message) in /_/src/Cli/dotnet/Installer/Windows/SetupLoggerBase.cs:line 19
   at Microsoft.DotNet.Installer.Windows.TimestampedFileLogger.ProcessLogRequests(Object logPipeName) in /_/src/Cli/dotnet/Installer/Windows/TimestampedFileLogger.cs:line 151

it is a flaky test reported a few times.

sdk/src/Cli/dotnet/Installer/Windows/TimestampedFileLogger.cs

Line 185 in 7c856e6

if (!_messageQueue.IsCompleted)

should be if (!_messageQueue.IsAddingCompleted)

LakshanF · 2022-07-27T20:49:02Z

I'm not familiar with this area to make a call but given its a flaky test, I wonder what we should next.

@marcpopMSFT, as this is the only one remaining issue, can you provide guidance on the next step please?

marcpopMSFT · 2022-07-27T21:50:08Z

Two options, fix the test or disable the test as merging on red is not preferred. In this case, kasperk81 provided a suggested fix so I went ahead and just made that change.

kasperk81 · 2022-07-27T23:15:11Z

thanks. remaining failure is #26715 (comment). ⬅️ @AaronRobinsonMSFT, @jkoritzinsky, @elinor-fung (any workaround / disabling tests would be appreciated as this is blocking dotnet/installer#14170 as well and community cannot test anything new days before rc1..)

jkoritzinsky · 2022-07-27T23:34:19Z

I can take a look. If we want to just get this in though, we can disable the diagnostic that's causing the build failure, CA1420 (though I don't understand how a build failure is leading to these test failures) and then investigate later

elinor-fung · 2022-07-28T00:02:52Z

The PackageInstall failures look like a restore failure with an invalid NuGet source, not the diagnostic @LakshanF mentioned?

From log:

    Microsoft.DotNet.PackageInstall.Tests.ToolPackageInstallerTests.GivenAnInstalledPackageUninstallRemovesThePackage(testMockBehaviorIsInSync: False) [FAIL]
      Microsoft.DotNet.ToolPackage.ToolPackageException : The tool package could not be restored.
      Stack Trace:
        /_/src/Tests/Microsoft.DotNet.PackageInstall.Tests/Stage2ProjectRestorer.cs(79,0): at Microsoft.DotNet.Tools.Tool.Install.Stage2ProjectRestorer.Restore(FilePath project, PackageLocation packageLocation, String verbosity)
        /_/src/Cli/dotnet/ToolPackage/ToolPackageInstaller.cs(67,0): at Microsoft.DotNet.ToolPackage.ToolPackageInstaller.<>c__DisplayClass5_0.<InstallPackage>b__0()
        /_/src/Cli/dotnet/TransactionalAction.cs(85,0): at Microsoft.DotNet.Cli.TransactionalAction.Run[T](Func`1 action, Action commit, Action rollback)
        /_/src/Cli/dotnet/ToolPackage/ToolPackageInstaller.cs(48,0): at Microsoft.DotNet.ToolPackage.ToolPackageInstaller.InstallPackage(PackageLocation packageLocation, PackageId packageId, VersionRange versionRange, String targetFramework, String verbosity)
        /_/src/Tests/Microsoft.DotNet.PackageInstall.Tests/ToolPackageInstallerTests.cs(604,0): at Microsoft.DotNet.PackageInstall.Tests.ToolPackageInstallerTests.GivenAnInstalledPackageUninstallRemovesThePackage(Boolean testMockBehaviorIsInSync)
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
           at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      Output:
        > C:\h\w\A6C20929\p\d\dotnet.exe restore C:\h\w\A6C20929\t\azkgfkwc.l3e\cgdor0sd.qab.csproj --runtime any -v:quiet
        C:\h\w\A6C20929\t\azkgfkwc.l3e\cgdor0sd.qab.csproj : error NU1301: The local source 'C:\h\w\B66809BC\p\d\.nuget' doesn't exist.
        C:\h\w\A6C20929\t\azkgfkwc.l3e\cgdor0sd.qab.csproj : error NU1301: The local source 'C:\h\w\B2DE0975\p\d\.nuget' doesn't exist.
        C:\h\w\A6C20929\t\azkgfkwc.l3e\cgdor0sd.qab.csproj : error NU1301: The local source 'C:\h\w\BED60A55\p\d\.nuget' doesn't exist.
        Exit Code: 1

elinor-fung · 2022-07-28T00:53:42Z

@marcpopMSFT are the PackageInstall test failures around the NuGet source related to #26843?

marcpopMSFT · 2022-07-28T16:34:49Z

@marcpopMSFT are the PackageInstall test failures around the NuGet source related to #26843?
@elinor-fung yes. If the tests get run on a helix machine that was previously used for sdk tests, they'll failed. That PR should fix that issue.

ghost added the Area-CodeFlow label Jul 20, 2022

dotnet-maestro bot added 2 commits July 22, 2022 12:39

kasperk81 mentioned this pull request Jul 24, 2022

Native AOT runtime changes for multiple package conflict dotnet/runtime#72346

Merged

dotnet-maestro bot added 2 commits July 24, 2022 12:24

Native AOT publish changes to be active after runtime changes (#26780)

acdef9a

Fix typo in HostWriter.CreateAppHost (#26786)

524c8b2

LakshanF mentioned this pull request Jul 25, 2022

[NativeAot] Fix GivenThatWeWantToPublishAnAotApp so as to set the PublishAot property via AdditionalProperties #26791

Closed

LakshanF and others added 4 commits July 25, 2022 16:56

Change tests to workaround #26791

59453c0

Fix aot telemetry test

30af62f

Fixing tests for the new Trimmer additional warning

e2c7716

revert back to setting PublishAot in the project

be39d9a

marcpopMSFT mentioned this pull request Jul 27, 2022

[main] Update dependencies from dotnet/sdk dotnet/installer#14170

Merged

Update to IsAddingCompleted

71a6a68

marcpopMSFT approved these changes Jul 27, 2022

View reviewed changes

marcpopMSFT enabled auto-merge July 27, 2022 21:50

marcpopMSFT merged commit 375955d into main Jul 28, 2022

marcpopMSFT deleted the darc-main-2ac5783b-d32c-4aed-ba67-43d81bc922cc branch July 28, 2022 03:32

LakshanF mentioned this pull request Jul 29, 2022

Native AOT publish changes to be active after runtime changes #26652

Closed

[main] Update dependencies from dotnet/runtime #26715

[main] Update dependencies from dotnet/runtime #26715

Uh oh!

Conversation

dotnet-maestro bot commented Jul 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/runtime

Uh oh!

dotnet-maestro bot commented Jul 20, 2022

Notification for subscribed users from https://github.com/dotnet/runtime:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

Uh oh!

kasperk81 commented Jul 20, 2022

Uh oh!

jkoritzinsky commented Jul 20, 2022

Uh oh!

jkoritzinsky commented Jul 20, 2022

Uh oh!

dotnet-maestro bot commented Jul 20, 2022

Notification for subscribed users from https://github.com/dotnet/runtime:

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

Uh oh!

kasperk81 commented Jul 21, 2022

Uh oh!

jkoritzinsky commented Jul 21, 2022

Uh oh!

kasperk81 commented Jul 24, 2022

Uh oh!

jkoritzinsky commented Jul 24, 2022

Uh oh!

LakshanF commented Jul 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LakshanF commented Jul 25, 2022

Uh oh!

LakshanF commented Jul 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LakshanF commented Jul 27, 2022

Uh oh!

kasperk81 commented Jul 27, 2022

Uh oh!

LakshanF commented Jul 27, 2022

Uh oh!

kasperk81 commented Jul 27, 2022

Uh oh!

kasperk81 commented Jul 27, 2022

Uh oh!

LakshanF commented Jul 27, 2022

Uh oh!

marcpopMSFT commented Jul 27, 2022

Uh oh!

kasperk81 commented Jul 27, 2022

Uh oh!

jkoritzinsky commented Jul 27, 2022

Uh oh!

elinor-fung commented Jul 28, 2022

Uh oh!

elinor-fung commented Jul 28, 2022

Uh oh!

marcpopMSFT commented Jul 28, 2022

Uh oh!

Uh oh!

dotnet-maestro bot commented Jul 20, 2022 •

edited

Loading

LakshanF commented Jul 25, 2022 •

edited

Loading

LakshanF commented Jul 26, 2022 •

edited

Loading