Skip to content

Allow file changes from tar as it's just a warning #24971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 26, 2022
Merged

Allow file changes from tar as it's just a warning #24971

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce82ee4
I kept seeing tar errors in our builds. it turns out that tar returni…
marcpopMSFT Apr 20, 2022
ddcb438
Fix warning format
marcpopMSFT Apr 21, 2022
46955e4
Ignore returncode==1
marcpopMSFT Apr 22, 2022
fa9625d
Update src/Tests/HelixTasks/TarGzFileCreateFromDirectory.cs
marcpopMSFT Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Tests/HelixTasks/TarGzFileCreateFromDirectory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@ public sealed class TarGzFileCreateFromDirectory : ToolTask
protected override int ExecuteTool(string pathToTool, string responseFileCommands, string commandLineCommands)
{
int returnCode = base.ExecuteTool(pathToTool, responseFileCommands, commandLineCommands);

if (IgnoreExitCode)

// returnCode 1 indicates that files changed during tar. In our case, it is likely being overwritten by another copy of the same file, so we can safely ignore this warning.
if (IgnoreExitCode || returnCode == 1)
{
returnCode = 0;
}
Expand Down