Allow file changes from tar as it's just a warning #24971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng 1 means the files changed during execution. Let's allow that to be more reliable in our builds as I think this is from helix and non-helix together.
ghost
added
the
This was referenced Apr 25, 2022
|
Per dngeng, tar comes from the OS we use so this is the best solution we have for the moment. Also, the tar on OSX may not support the warning suppression we'd want to do anyway. |
Forgind
approved these changes
Apr 25, 2022
Forgind
reviewed
Apr 25, 2022
Co-authored-by: Forgind <Forgind@users.noreply.github.com>
|
looks good. does HelixTask.csproj require multiple frameworks or can it use a single |
marcpopMSFT
added a commit
that referenced
this pull request
Jun 20, 2022
Allow file changes from tar as it's just a warning
dotnet-maestro bot
added a commit
that referenced
this pull request
Jun 21, 2022
[release/6.0.4xx] Update dependencies from nuget/nuget.client - Merge pull request #24971 from dotnet/marcpopMSFT-allowtarchanges Allow file changes from tar as it's just a warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept seeing tar errors in our builds. it turns out that tar returning 1 means the files changed during execution. Let's allow that to be more reliable in our builds as I think this is from helix and non-helix together.
The version of tar we use doesn't support the --warning flag for this so map a returncode of 1 back to zero. In parallel, I'm digging into how our version of tar is determined.