Skip to content

[main] Update dependencies from dotnet/runtime #19495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 4, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 4, 2021

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
  • Build: 20210803.13
  • Date Produced: 8/4/2021 7:37 AM
  • Commit: c082af307d252a7ad755c729f1de55b6cfb25c5a
  • Branch: refs/heads/main

dotnet-maestro bot added 9 commits July 30, 2021 02:32
Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21378.1 -> To Version 6.0.100-preview.6.21379.2
Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21378.1 -> To Version 6.0.100-preview.6.21380.1
Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21378.1 -> To Version 6.0.100-preview.6.21380.2
Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21378.1 -> To Version 6.0.100-preview.6.21402.1
Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21378.1 -> To Version 6.0.100-preview.6.21402.2
Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21378.1 -> To Version 6.0.100-preview.6.21403.1
Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21378.1 -> To Version 6.0.100-preview.6.21403.2
Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21378.1 -> To Version 6.0.100-preview.6.21403.3
…0803.13

Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.Platforms , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Text.Encoding.CodePages , System.Security.Cryptography.ProtectedData , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 , System.Reflection.MetadataLoadContext , System.CodeDom , System.Resources.Extensions
 From Version 6.0.0-rc.1.21401.3 -> To Version 6.0.0-rc.1.21403.13
@ghost ghost added the Area-dotnet test label Aug 4, 2021
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Aug 4, 2021

Notification for subscribed users from https://github.com/dotnet/runtime:

@dnr-codeflow

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/runtime) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@lewing
Copy link
Member

lewing commented Aug 4, 2021

Looks like at least some of the failures are new trim analysis warnings.

cc @eerhardt

@lewing
Copy link
Member

lewing commented Aug 4, 2021

{ "HelixJobId": "209626bf-4ea0-4a83-929e-5463689af760", "HelixWorkItemName": "Microsoft.NET.Publish.Tests.dll.4" }


Error message
Target framework from test: net6.0
Runtime identifier: ubuntu.16.04-x64
Runtime Assembly Informational Version: 6.0.0-rc.1.21403.13+c082af307d252a7ad755c729f1de55b6cfb25c5a
The execution of a hello world app generated a diff in the number of warnings the app produces

Test output contained the following extra linker warnings:

ILLink : Trim analysis warning IL2026: System.Diagnostics.Tracing.EventSource.EnsureDescriptorsInitialized(): Using method 'System.Diagnostics.Tracing.EventSource.WriteEventWithRelatedActivityIdCore(Int32,Guid*,Int32,EventData*)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. EventSource will serialize the whole object graph. Trimmer will not safely handle this case because properties may be trimmed. This can be suppressed if the object is a primitive type. [/datadisks/disk1/work/A28008C6/w/A7330964/e/testExecutionDirectory/ILLink_verify---35F0AA90/AnalysisWarningsOnHelloWorldApp/AnalysisWarningsOnHelloWorldApp.csproj]
ILLink : Trim analysis warning IL2026: System.Diagnostics.Tracing.EventSource.EnsureDescriptorsInitialized(): Using method 'System.Diagnostics.Tracing.EventSource.Write<T>(String,EventSourceOptions&,Guid&,Guid&,T&)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. EventSource will serialize the whole object graph. Trimmer will not safely handle this case because properties may be trimmed. This can be suppressed if the object is a primitive type. [/datadisks/disk1/work/A28008C6/w/A7330964/e/testExecutionDirectory/ILLink_verify---35F0AA90/AnalysisWarningsOnHelloWorldApp/AnalysisWarningsOnHelloWorldApp.csproj]
ILLink : Trim analysis warning IL2026: System.Diagnostics.Tracing.EventSource.EnsureDescriptorsInitialized(): Using method 'System.Diagnostics.Tracing.EventSource.Write<T>(String,EventSourceOptions&,T&)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. EventSource will serialize the whole object graph. Trimmer will not safely handle this case because properties may be trimmed. This can be suppressed if the object is a primitive type. [/datadisks/disk1/work/A28008C6/w/A7330964/e/testExecutionDirectory/ILLink_verify---35F0AA90/AnalysisWarningsOnHelloWorldApp/AnalysisWarningsOnHelloWorldApp.csproj]
ILLink : Trim analysis warning IL2026: System.Diagnostics.Tracing.EventSource.EnsureDescriptorsInitialized(): Using method 'System.Diagnostics.Tracing.EventSource.Write<T>(String,EventSourceOptions,T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. EventSource will serialize the whole object graph. Trimmer will not safely handle this case because properties may be trimmed. This can be suppressed if the object is a primitive type. [/datadisks/disk1/work/A28008C6/w/A7330964/e/testExecutionDirectory/ILLink_verify---35F0AA90/AnalysisWarningsOnHelloWorldApp/AnalysisWarningsOnHelloWorldApp.csproj]
ILLink : Trim analysis warning IL2026: System.Diagnostics.Tracing.EventSource.EnsureDescriptorsInitialized(): Using method 'System.Diagnostics.Tracing.EventSource.Write<T>(String,T)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. EventSource will serialize the whole object graph. Trimmer will not safely handle this case because properties may be trimmed. This can be suppressed if the object is a primitive type. [/datadisks/disk1/work/A28008C6/w/A7330964/e/testExecutionDirectory/ILLink_verify---35F0AA90/AnalysisWarningsOnHelloWorldApp/AnalysisWarningsOnHelloWorldApp.csproj]
ILLink : Trim analysis warning IL2026: System.Diagnostics.Tracing.EventSource.EnsureDescriptorsInitialized(): Using method 'System.Diagnostics.Tracing.EventSource.SerializeEventArgs(Int32,Object[])' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. EventSource will serialize the whole object graph. Trimmer will

Stack trace
   at Microsoft.NET.Publish.Tests.GivenThatWeWantToRunILLink.ValidateWarningsOnHelloWorldApp(PublishCommand publishCommand, CommandResult result, String[] expectedOutput, String targetFramework, String rid) in /_/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink.cs:line 656
   at Microsoft.NET.Publish.Tests.GivenThatWeWantToRunILLink.ILLink_verify_analysis_warnings_hello_world_app_trim_mode_copyused(String targetFramework) in /_/src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToRunILLink.cs:line 607

in addition to the mock workload issue.

…e-40d1aaa96079' into darc-main-abbd2ec4-766e-407d-bc9c-8a7da21d4402
@sbomer
Copy link
Member

sbomer commented Aug 4, 2021

The runtime and linker changes need to be made together so the linker respects the new runtime suppressions - I pushed the linker update into this PR.

@eerhardt
Copy link
Member

eerhardt commented Aug 4, 2021

Thanks @sbomer !

@lewing
Copy link
Member

lewing commented Aug 4, 2021

This should go green once #19480 is in

@danmoseley
Copy link
Member

@lewing this test failure is occurring in many legs

System.AggregateException : One or more errors occurred. (The given key 'mock-workload-1' was not present in the dictionary.)\n---- System.Collections.Generic.KeyNotFoundException : The given key 'mock-workload-1' was not present in the dictionary.

https://dev.azure.com/dnceng/public/_build/results?buildId=1275968&view=ms.vss-test-web.build-test-results-tab&runId=37742228&resultId=100921&paneView=debug

could you take a look?

@eerhardt
Copy link
Member

eerhardt commented Aug 4, 2021

'mock-workload-1' was not present in the dictionary.)\n---- System.Collections.Generic.KeyNotFoundException : The given key 'mock-workload-1' was not present in the dictionary.

I assume that is what @lewing meant with

This should go green once #19480 is in

@lewing
Copy link
Member

lewing commented Aug 4, 2021

yes, see the discussion there

@lewing
Copy link
Member

lewing commented Aug 4, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lewing lewing merged commit 1cde09f into main Aug 4, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-main-abbd2ec4-766e-407d-bc9c-8a7da21d4402 branch August 4, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants