Skip to content

[main] Update dependencies from mono/linker #19412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 30, 2021

This pull request updates the following dependencies

From https://github.com/mono/linker

  • Subscription: 4a865c13-5e52-41f5-3916-08d8e9750bf8
  • Build: 20210803.3
  • Date Produced: 8/3/2021 11:55 PM
  • Commit: 7cb5aafb7314384229bd05b2aeb9e21805f463f9
  • Branch: refs/heads/main

Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21378.1 -> To Version 6.0.100-preview.6.21379.2
@ghost
Copy link

ghost commented Jul 30, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/mono/linker:

@marek-safer

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/mono/linker) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

dotnet-maestro bot added 4 commits July 30, 2021 23:52
Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21378.1 -> To Version 6.0.100-preview.6.21380.1
Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21378.1 -> To Version 6.0.100-preview.6.21380.2
Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21378.1 -> To Version 6.0.100-preview.6.21402.1
Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21378.1 -> To Version 6.0.100-preview.6.21402.2
@joeloff
Copy link
Member

joeloff commented Aug 3, 2021

@pranavkm looks like there's a WASM publishing test that's failing with IL warnings around trimming:

Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmPublishIntegrationTest.Publish_MinimalApp_Works [FAIL]
 C:\h\w\9D9008E8\w\B40B09BE\e\Assets\.nuget\packages\microsoft.netcore.app.runtime.mono.browser-wasm\6.0.0-rc.1.21401.3\runtimes\browser-wasm\lib\net6.0\System.Linq.Expressions.dll : warning IL2104: Assembly 'System.Linq.Expressions' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [C:\h\w\9D9008E8\t\dotnetSdkTests\bzi5s2ak.s2x\Publish_Minim---C83C20DE\blazorwasm-minimal.csproj]
      C:\h\w\9D9008E8\w\B40B09BE\e\Assets\.nuget\packages\microsoft.netcore.app.runtime.mono.browser-wasm\6.0.0-rc.1.21401.3\runtimes\browser-wasm\native\System.Private.CoreLib.dll : warning IL2104: Assembly 'System.Private.CoreLib' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries [C:\h\w\9D9008E8\t\dotnetSdkTests\bzi5s2ak.s2x\Publish_Minim---C83C20DE\blazorwasm-minimal.csproj]
        Creating "obj\Debug\net6.0\linked\Link.semaphore" because "AlwaysCreate" was specified.

Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21378.1 -> To Version 6.0.100-preview.6.21403.1
@mkArtakMSFT
Copy link
Contributor

@eerhardt do you know what may be causing this? Thanks!

Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21378.1 -> To Version 6.0.100-preview.6.21403.2
@eerhardt
Copy link
Member

eerhardt commented Aug 3, 2021

It looks like it is probably dotnet/linker#2145 that is causing this. To fix it, we will need to wait for dotnet/runtime#56593 to be merged and then flown into the SDK.

cc @agocke @sbomer

Microsoft.NET.ILLink.Analyzers , Microsoft.NET.ILLink.Tasks
 From Version 6.0.100-preview.6.21378.1 -> To Version 6.0.100-preview.6.21403.3
@lewing
Copy link
Member

lewing commented Aug 4, 2021

If this is waiting on runtime we'll need to resolve #19495

@lewing
Copy link
Member

lewing commented Aug 4, 2021

closing this in favor of #19495

@lewing lewing closed this Aug 4, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-main-57331392-bfb9-474d-b9ae-40d1aaa96079 branch August 4, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants