[main] Update dependencies from dotnet/runtime #16810

dotnet-maestro · 2021-04-09T12:19:16Z

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

Subscription: aa69f164-2492-460a-3914-08d8e9750bf8
Build: 20210413.3
Date Produced: 4/13/2021 3:11 PM
Commit: 5d0817a2136b84580a78fea5bfbe9910098bed2b
Branch: refs/heads/main

Updates:
- Microsoft.NETCore.Platforms: from 6.0.0-preview.4.21207.11 to 6.0.0-preview.4.21213.3
- Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-preview.4.21207.11 to 6.0.0-preview.4.21213.3
- Microsoft.NETCore.DotNetHostResolver: from 6.0.0-preview.4.21207.11 to 6.0.0-preview.4.21213.3
- Microsoft.NET.HostModel: from 6.0.0-preview.4.21207.11 to 6.0.0-preview.4.21213.3
- Microsoft.Extensions.DependencyModel: from 6.0.0-preview.4.21207.11 to 6.0.0-preview.4.21213.3
- Microsoft.NETCore.App.Host.win-x64: from 6.0.0-preview.4.21207.11 to 6.0.0-preview.4.21213.3
- Microsoft.NETCore.App.Ref: from 6.0.0-preview.4.21207.11 to 6.0.0-preview.4.21213.3
- System.Reflection.MetadataLoadContext: from 6.0.0-preview.4.21207.11 to 6.0.0-preview.4.21213.3
- System.Resources.Extensions: from 6.0.0-preview.4.21207.11 to 6.0.0-preview.4.21213.3
- System.CodeDom: from 6.0.0-preview.4.21207.11 to 6.0.0-preview.4.21213.3
- VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-preview.4.21207.11 to 6.0.0-preview.4.21213.3
- System.Security.Cryptography.ProtectedData: from 6.0.0-preview.4.21207.11 to 6.0.0-preview.4.21213.3
- System.Text.Encoding.CodePages: from 6.0.0-preview.4.21207.11 to 6.0.0-preview.4.21213.3

…0409.1 Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 6.0.0-preview.4.21207.11 -> To Version 6.0.0-preview.4.21209.1

ghost · 2021-04-09T12:19:19Z

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

jeffschwMSFT · 2021-04-09T15:44:24Z

Rerunning as there were 5 sdk tests failures

jeffschwMSFT · 2021-04-09T17:28:21Z

This round seems to fail due to restore failures:

A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

C:\h\w\B5080A10\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: The "ResolvePackageAssets" task failed unexpectedly.

jeffschwMSFT · 2021-04-09T18:49:30Z

@marcpopMSFT are you seeing in stability across the sdk repo? This pr seems to be in a whack a mole issue hunt with azure. Here is a new one:

python.exe -c "import future" || C:\Users\runner.azdo-env\Scripts\python.exe -m pip install future==0.17.1
Traceback (most recent call last):
File "", line 1, in
ModuleNotFoundError: No module named 'future'

marcpopMSFT · 2021-04-09T18:57:32Z

@jeffschwMSFT we have been having a lot of stability issues mainly related to ADO feeds throttling us and overlapping test directories. They've increased the limits for us, we've fixed the test directory at the beginning of this week, and added a retry on restore such that at least earlier this week, our reliability was looking very good. Today though is having a lot of issues so I'm not sure if there is system problem today or we just got lucky earlier in the week.

@dsplaisted is on build duty. Given the high number of failures in this run (we usually see a smaller number), might be a system problem or an issue in the payload.

jeffschwMSFT · 2021-04-09T21:51:11Z

@dsplaisted will you get a chance to take a look? The current set of failures look different than the last set, which is true of the first set.

dsplaisted · 2021-04-09T23:52:51Z

@jeffschwMSFT This looks like it might be a break in the runtime that is being inserted. I'm seeing a failure down in the System.IO code:

C:\h\w\A6D10962\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: The "ResolvePackageAssets" task failed unexpectedly. [C:\h\w\A6D10962\t\dotnetSdkTests\figp5j5f.tn0\PackMultiTargetedLibrary\PackMultiTargetedLibrary\PackMultiTargetedLibrary.csproj]
C:\h\w\A6D10962\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. [C:\h\w\A6D10962\t\dotnetSdkTests\figp5j5f.tn0\PackMultiTargetedLibrary\PackMultiTargetedLibrary\PackMultiTargetedLibrary.csproj]
C:\h\w\A6D10962\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: at System.IO.Strategies.SyncWindowsFileStreamStrategy.Write(Byte[] buffer, Int32 offset, Int32 count) [C:\h\w\A6D10962\t\dotnetSdkTests\figp5j5f.tn0\PackMultiTargetedLibrary\PackMultiTargetedLibrary\PackMultiTargetedLibrary.csproj]
C:\h\w\A6D10962\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: at System.IO.Strategies.BufferedFileStreamStrategy.Flush(Boolean flushToDisk) [C:\h\w\A6D10962\t\dotnetSdkTests\figp5j5f.tn0\PackMultiTargetedLibrary\PackMultiTargetedLibrary\PackMultiTargetedLibrary.csproj]
C:\h\w\A6D10962\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: at System.IO.Strategies.BufferedFileStreamStrategy.Dispose(Boolean disposing) [C:\h\w\A6D10962\t\dotnetSdkTests\figp5j5f.tn0\PackMultiTargetedLibrary\PackMultiTargetedLibrary\PackMultiTargetedLibrary.csproj]
C:\h\w\A6D10962\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: at System.IO.Stream.Close() [C:\h\w\A6D10962\t\dotnetSdkTests\figp5j5f.tn0\PackMultiTargetedLibrary\PackMultiTargetedLibrary\PackMultiTargetedLibrary.csproj]
C:\h\w\A6D10962\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: at System.IO.BinaryWriter.Dispose(Boolean disposing) [C:\h\w\A6D10962\t\dotnetSdkTests\figp5j5f.tn0\PackMultiTargetedLibrary\PackMultiTargetedLibrary\PackMultiTargetedLibrary.csproj]
C:\h\w\A6D10962\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: at System.IO.BinaryWriter.Dispose() [C:\h\w\A6D10962\t\dotnetSdkTests\figp5j5f.tn0\PackMultiTargetedLibrary\PackMultiTargetedLibrary\PackMultiTargetedLibrary.csproj]
C:\h\w\A6D10962\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: at Microsoft.NET.Build.Tasks.ResolvePackageAssets.CacheWriter.WriteToCacheFile() in //src/Tasks/Microsoft.NET.Build.Tasks/ResolvePackageAssets.cs:line 704 [C:\h\w\A6D10962\t\dotnetSdkTests\figp5j5f.tn0\PackMultiTargetedLibrary\PackMultiTargetedLibrary\PackMultiTargetedLibrary.csproj]
C:\h\w\A6D10962\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: at Microsoft.NET.Build.Tasks.ResolvePackageAssets.CacheReader.CreateReaderFromDisk(ResolvePackageAssets task, Byte[] settingsHash) in //src/Tasks/Microsoft.NET.Build.Tasks/ResolvePackageAssets.cs:line 520 [C:\h\w\A6D10962\t\dotnetSdkTests\figp5j5f.tn0\PackMultiTargetedLibrary\PackMultiTargetedLibrary\PackMultiTargetedLibrary.csproj]
C:\h\w\A6D10962\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: at Microsoft.NET.Build.Tasks.ResolvePackageAssets.CacheReader..ctor(ResolvePackageAssets task) in //src/Tasks/Microsoft.NET.Build.Tasks/ResolvePackageAssets.cs:line 468 [C:\h\w\A6D10962\t\dotnetSdkTests\figp5j5f.tn0\PackMultiTargetedLibrary\PackMultiTargetedLibrary\PackMultiTargetedLibrary.csproj]
C:\h\w\A6D10962\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: at Microsoft.NET.Build.Tasks.ResolvePackageAssets.ReadItemGroups() in //src/Tasks/Microsoft.NET.Build.Tasks/ResolvePackageAssets.cs:line 300 [C:\h\w\A6D10962\t\dotnetSdkTests\figp5j5f.tn0\PackMultiTargetedLibrary\PackMultiTargetedLibrary\PackMultiTargetedLibrary.csproj]
C:\h\w\A6D10962\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: at Microsoft.NET.Build.Tasks.ResolvePackageAssets.ExecuteCore() in //src/Tasks/Microsoft.NET.Build.Tasks/ResolvePackageAssets.cs:line 292 [C:\h\w\A6D10962\t\dotnetSdkTests\figp5j5f.tn0\PackMultiTargetedLibrary\PackMultiTargetedLibrary\PackMultiTargetedLibrary.csproj]
C:\h\w\A6D10962\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: at Microsoft.NET.Build.Tasks.TaskBase.Execute() in //src/Tasks/Common/TaskBase.cs:line 38 [C:\h\w\A6D10962\t\dotnetSdkTests\figp5j5f.tn0\PackMultiTargetedLibrary\PackMultiTargetedLibrary\PackMultiTargetedLibrary.csproj]
C:\h\w\A6D10962\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [C:\h\w\A6D10962\t\dotnetSdkTests\figp5j5f.tn0\PackMultiTargetedLibrary\PackMultiTargetedLibrary\PackMultiTargetedLibrary.csproj]
C:\h\w\A6D10962\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [C:\h\w\A6D10962\t\dotnetSdkTests\figp5j5f.tn0\PackMultiTargetedLibrary\PackMultiTargetedLibrary\PackMultiTargetedLibrary.csproj]

Is this the failure you were seeing?

jeffschwMSFT · 2021-04-09T23:55:32Z

Only on this most recent retry. I don't have the previous logs, but I do not think it was due to this. Adding @jeffhandley .

…0409.14 Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 6.0.0-preview.4.21207.11 -> To Version 6.0.0-preview.4.21209.14

…0411.1 Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 6.0.0-preview.4.21207.11 -> To Version 6.0.0-preview.4.21211.1

…0411.7 Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 6.0.0-preview.4.21207.11 -> To Version 6.0.0-preview.4.21211.7

jeffschwMSFT · 2021-04-12T16:24:59Z

@jeffhandley can you take a look at these IO failures?
https://helix.dot.net/api/2019-06-17/jobs/58c00372-d80f-4849-8d3d-af0a41789bf1/workitems/Microsoft.NET.Build.Tests.dll.5/console
https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-sdk-refs-pull-16810-merge-597bfe36397d4bb388/Microsoft.NET.Build.Tests.dll.4/console.92c43082.log?sv=2019-07-07&se=2021-05-02T15%3A12%3A31Z&sr=c&sp=rl&sig=EYSlR%2FEfp9ClPkVhihg6Tx77vIQx6zi8t0Ah8UlFqoE%3D
https://helix.dot.net/api/2019-06-17/jobs/597bfe36-397d-4bb3-88e1-5cd89b2526a3/workitems/Microsoft.NET.Build.Tests.dll.3/console

cc @danmoseley

jeffhandley · 2021-04-12T16:56:08Z

@adamsitnik @carlossanlop @jozkee -- These errors look to be caused by the recent changes to FileStream. Please take a look right away to determine what we need to do here.

Here's the trimmed up call stack:

    Microsoft.NET.Build.Tests.GivenThatWeWantToBuildAnAppWithoutTransitiveProjectRefs.It_builds_the_project_successfully_when_RAR_finds_all_references [FAIL]
      The "ResolvePackageAssets" task failed unexpectedly. [C:\h\w\A224091D\t\dotnetSdkTests\btnehx1n.s1g\It_builds_the---6B3FC006\3\3.csproj]
      System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values.
         at System.IO.Strategies.SyncWindowsFileStreamStrategy.Write(Byte[] buffer, Int32 offset, Int32 count)
         at System.IO.Strategies.BufferedFileStreamStrategy.Flush(Boolean flushToDisk)
         at System.IO.Strategies.BufferedFileStreamStrategy.Dispose(Boolean disposing)
         at System.IO.Strategies.BufferedFileStreamStrategy.DisposeInternal(Boolean disposing)
         at System.IO.FileStream.Dispose(Boolean disposing)
         at System.IO.Stream.Close()
         at System.IO.BinaryWriter.Dispose(Boolean disposing)
         at System.IO.BinaryWriter.Dispose()
         at Microsoft.NET.Build.Tasks.ResolvePackageAssets.CacheWriter.WriteToCacheFile() in /_/src/Tasks/Microsoft.NET.Build.Tasks/ResolvePackageAssets.cs:line 704
         at Microsoft.NET.Build.Tasks.ResolvePackageAssets.CacheReader.CreateReaderFromDisk(ResolvePackageAssets task, Byte[] settingsHash) in /_/src/Tasks/Microsoft.NET.Build.Tasks/ResolvePackageAssets.cs:line 520
         at Microsoft.NET.Build.Tasks.ResolvePackageAssets.CacheReader..ctor(ResolvePackageAssets task) in /_/src/Tasks/Microsoft.NET.Build.Tasks/ResolvePackageAssets.cs:line 468
         at Microsoft.NET.Build.Tasks.ResolvePackageAssets.ReadItemGroups() in /_/src/Tasks/Microsoft.NET.Build.Tasks/ResolvePackageAssets.cs:line 300
         at Microsoft.NET.Build.Tasks.ResolvePackageAssets.ExecuteCore() in /_/src/Tasks/Microsoft.NET.Build.Tasks/ResolvePackageAssets.cs:line 292
         at Microsoft.NET.Build.Tasks.TaskBase.Execute() in /_/src/Tasks/Common/TaskBase.cs:line 38
         at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
         at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)

adamsitnik · 2021-04-12T17:40:26Z

@carlossanlop @jozkee repro:

git clone https://github.com/dotnet/sdk repro
cd repro
git checkout darc-main-0fd96bf7-148d-4cf6-97b0-d3934c67609e
.\build.cmd -c Debug
.\.dotnet\dotnet.exe test -c Debug src\Tests\Microsoft.NET.Build.Tests\Microsoft.NET.Build.Tests.csproj --filter Microsoft.NET.Build.Tests.GivenThatWeWantToBuildASelfContainedApp.It_succeeds_when_RuntimeIdentifier_and_PlatformTarget_mismatch_but_PT_is_AnyCPU

carlossanlop · 2021-04-12T20:02:00Z

@jeffschwMSFT @marcpopMSFT we have a runtime PR out to revert the compat flag that enabled the new FileStream rewrite by default. This will unblock dotnet/sdk and will allow us to investigate the root cause more carefully.

marcpopMSFT · 2021-04-12T21:21:19Z

Thanks @carlossanlop. Please prioritize getting that in and flowing as this PR is needed to unblocked dotnet/installer#10185 and I need a new build of installer with runtime changes to insert into VS previews as well.

CC @joeloff

carlossanlop · 2021-04-12T23:07:36Z

Update: We have a PR out to fix the actual issue. If the CI of that PR finishes successfully, we'll get that merged. Otherwise, we'll merge my PR reverting the compat flag change.

carlossanlop · 2021-04-13T06:59:48Z

The PR with the fix was merged. Is dotnet-maestro going to update this PR automatically with the commit that contains the fix, or do we need to do something manually?

joeloff · 2021-04-13T07:26:08Z

Hopefully it is updated by maestro once a new runtime build is ready

…0413.1 Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 6.0.0-preview.4.21207.11 -> To Version 6.0.0-preview.4.21213.1

jeffschwMSFT · 2021-04-13T14:06:09Z

Thanks @carlossanlop. The current failures are due to a missing browswer wasm package.

/private/tmp/helix/working/ABAC0950/w/B36A0A16/e/testExecutionDirectory/BuildMinimal_---F77D8391/blazorwasm-minimal.csproj : error NU1102: Unable to find package Microsoft.NETCore.App.Runtime.browser-wasm with version (= 6.0.0-preview.4.21213.1)

@marek-safar @steveisok can y'all take a look at what is missing?

marek-safar · 2021-04-13T14:20:33Z

@steveisok that's the renaming issue, right?

steveisok · 2021-04-13T14:21:49Z

Yes, we are working on fixing

…0413.3 Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 6.0.0-preview.4.21207.11 -> To Version 6.0.0-preview.4.21213.3

jeffschwMSFT · 2021-04-13T18:25:59Z

@steveisok the run just finished and we are now seeing the following: Unable to find package Microsoft.NETCore.App.Runtime.browser-wasm with version (= 6.0.0-preview.4.21213.3)

akoeplinger · 2021-04-13T18:30:28Z

@jeffschwMSFT dotnet/installer#10206 is part of the fix.

…er by default

marcpopMSFT · 2021-04-13T20:17:35Z

Installer change is merged now.

pranavkm · 2021-04-13T20:51:29Z

@marcpopMSFT would unblocking this PR need a new stage0 SDK?

marcpopMSFT · 2021-04-13T21:59:49Z

@pranavkm The changes made to OverrideAndCreateBundledNETCoreAppPackageVersion.cs allow them to avoid needing a stage 0 update. It basically adds the changes that would be from the new installer build to avoid the sdk vs. installer deadlock.

marcpopMSFT · 2021-04-13T22:00:42Z

@dotnet/dnceng The Ubuntu build has been queued for an hour now without starting. Is there an issue in the lab with resources or too many builds at once?

ulisesh · 2021-04-13T22:04:28Z

@marcpopMSFT yes, the queue is its max capacity limit. I just scaled the queue over this limit to speed things up.

FYI, the capacity limit will be increased tomorrow to prevent this.

markwilkie · 2021-04-13T22:05:39Z

What's the best way for folks like @marcpopMSFT to look at the queue depth themselves?

ulisesh · 2021-04-13T22:14:07Z

There is a Helix API call that you can do to get the queueDepth

You can call https://helix.dot.net/api/info/queues/buildpool.ubuntu.1604.amd64.open?includeQueueDepth=true&api-version=2019-06-17 but it looks like the information isn't correct. @MattGal @alexperovich do you know if we stopped supporting this?

MattGal · 2021-04-13T22:15:30Z

There is a Helix API call that you can do to get the queueDepth

You can call https://helix.dot.net/api/info/queues/buildpool.ubuntu.1604.amd64.open?includeQueueDepth=true&api-version=2019-06-17 but it looks like the information isn't correct. @MattGal @alexperovich do you know if we stopped supporting this?

new to me, checking it out.

MattGal · 2021-04-13T22:22:30Z

Um. I think it's an artifact from when @alexperovich rewrote the API? The old one has it the newer one doesn't really

            int queueDepth = 0;

            if (includeQueueDepth)
            {
                // TODO: get this
            }

MattGal · 2021-04-13T22:26:50Z

It's intentional on both API versions:

#pragma warning disable 1998
        private async Task<long> GetQueueDepth(string queueId)
#pragma warning restore 1998
        {
            // we are unable to get this with the current sdks
            // replace this when we switch to Helix.Utility.Azure stuff
            Trace.WriteLine(_serviceBusClientFactory.GetType().Name);

... looks like updating SDKs took away functionality, sorry users!

markwilkie · 2021-04-13T22:32:10Z

Remind me again what we use for our grafana alerting?

ulisesh · 2021-04-13T22:44:33Z

Our monitoring system definitely has the queue depth information @marcpopMSFT was looking for. I'll share it with him but it isn't recommended approach for all users

MattGal · 2021-04-13T22:45:55Z

Our monitoring system definitely has the queue depth information @marcpopMSFT was looking for. I'll share it with him but it isn't recommended approach for all users

it probably just uses the old SDK where that API was still available.

markwilkie · 2021-04-13T22:46:32Z

it probably just uses the old SDK where that API was still available.

That makes sense. Marc could just use that too yes?

MattGal · 2021-04-13T22:49:45Z

it probably just uses the old SDK where that API was still available.

That makes sense. Marc could just use that too yes?

Correct, we just don't usually point users at Grafana as @ulisesh said.

marcpopMSFT · 2021-04-13T22:51:20Z

@markwilkie PR improvement suggestion to show the queue in the new PR experience. I can certainly use the dashboard or api but I'll likely forget before the next time it gets backed up on a high visibility change.

markwilkie · 2021-04-13T22:54:27Z

@garath / @missymessa - could one of you make sure we're tracking the suggestion to add queue depth to the PR experience please?

@marcpopMSFT - it'll be good to track this, but given that the build won't even have started, it'll be tough to show results of something that hasn't started yet. :) Sounds like you could make an API call as well....

@garath / @ilyas1974 - what's the latest thinking around opening up grafana for more folks to see. My thinking is to allow folks to self-help queue depth. thoughts?

ilyas1974 · 2021-04-13T23:05:42Z

No issues on my side opening up Grafana to more of our customers to view queue status.

Is the scenario you're thinking about something like - my build didn't start properly (i.e. couldn't get a machine before timeout) and in the failure we also show what the current queue depth is?

jeffschwMSFT · 2021-04-13T23:25:04Z

woot! Thanks everyone

marcpopMSFT · 2021-04-13T23:25:41Z

My scenario was: "All the builds are started except for Ubuntu. Why is it still queued and how long should I expect to wait?" That's why I pinged dnceng in the first place as this PR was blocking an installer PR which was blocking a VS PR....lots waiting for it to get fixed.

markwilkie · 2021-04-14T00:43:45Z

Is opening up grafana something you can follow up on by any chance @ilyas1974 ? Probably check w/ @Chrisboh etc to see what (if anything) we need to think about. If you're full up, I can do it as well, just let me know.

ilyas1974 · 2021-04-14T14:22:48Z

Happy to help to drive this.

@marcpopMSFT, for your specific scenario, hooking into Grafana may not provide the answers you are looking for.

With Grafana, we only have visibility into the non-hosted pools.
While Grafana has the potential to answer the second part of your question - how long should I expect to wait - it will not address the first part - Why is it still queued.
- What it sounds like you are asking for is a centralized location that lists on-going issues.

garath · 2021-04-22T16:22:03Z

could one of you make sure we're tracking the suggestion to add queue depth to the PR experience please?

I've opened dotnet/core-eng#12899 in the epic to track.

dotnet-maestro bot added 3 commits April 10, 2021 12:39

jkoritzinsky mentioned this pull request Apr 12, 2021

[6.0.100-preview.4.21206.10][main branch] LibGit2Sharp System.NullReferenceException at git_diff_find_similar native method dotnet/runtime#50841

Closed

This was referenced Apr 12, 2021

Fix test failures found in dotnet/sdk when opting-into the new FileStream strategy mode dotnet/runtime#51141

Closed

Revert "Disable Net5CompatFileStream by default (#50166)" dotnet/runtime#51142

Closed

am11 mentioned this pull request Apr 13, 2021

Single-file publish includes unnecessary files in the output #16487

Closed

akoeplinger mentioned this pull request Apr 13, 2021

Add KnownRuntimePack entries for Mono-based runtime packs dotnet/installer#10206

Merged

Add option for choosing Mono runtime pack and set it for mobile/brows…

b033633

…er by default

dotnet-maestro bot merged commit 173aca9 into main Apr 13, 2021

dotnet-maestro bot deleted the darc-main-0fd96bf7-148d-4cf6-97b0-d3934c67609e branch April 13, 2021 23:23

lewing mentioned this pull request Apr 14, 2021

[wasm][aot] Blazor template AOT fails in IcalTableGenerator dotnet/runtime#51195

Closed

[main] Update dependencies from dotnet/runtime #16810

[main] Update dependencies from dotnet/runtime #16810

Uh oh!

Conversation

dotnet-maestro bot commented Apr 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/runtime

Uh oh!

ghost commented Apr 9, 2021

Uh oh!

jeffschwMSFT commented Apr 9, 2021

Uh oh!

jeffschwMSFT commented Apr 9, 2021

Uh oh!

jeffschwMSFT commented Apr 9, 2021

Uh oh!

marcpopMSFT commented Apr 9, 2021

Uh oh!

jeffschwMSFT commented Apr 9, 2021

Uh oh!

dsplaisted commented Apr 9, 2021

Uh oh!

jeffschwMSFT commented Apr 9, 2021

Uh oh!

jeffschwMSFT commented Apr 12, 2021

Uh oh!

jeffhandley commented Apr 12, 2021

Uh oh!

adamsitnik commented Apr 12, 2021 • edited by carlossanlop Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carlossanlop commented Apr 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcpopMSFT commented Apr 12, 2021

Uh oh!

carlossanlop commented Apr 12, 2021

Uh oh!

carlossanlop commented Apr 13, 2021

Uh oh!

joeloff commented Apr 13, 2021

Uh oh!

jeffschwMSFT commented Apr 13, 2021

Uh oh!

marek-safar commented Apr 13, 2021

Uh oh!

steveisok commented Apr 13, 2021

Uh oh!

jeffschwMSFT commented Apr 13, 2021

Uh oh!

akoeplinger commented Apr 13, 2021

Uh oh!

marcpopMSFT commented Apr 13, 2021

Uh oh!

pranavkm commented Apr 13, 2021

Uh oh!

marcpopMSFT commented Apr 13, 2021

Uh oh!

marcpopMSFT commented Apr 13, 2021

Uh oh!

ulisesh commented Apr 13, 2021

Uh oh!

markwilkie commented Apr 13, 2021

Uh oh!

ulisesh commented Apr 13, 2021

Uh oh!

MattGal commented Apr 13, 2021

Uh oh!

MattGal commented Apr 13, 2021

Uh oh!

MattGal commented Apr 13, 2021

Uh oh!

markwilkie commented Apr 13, 2021

Uh oh!

ulisesh commented Apr 13, 2021

Uh oh!

MattGal commented Apr 13, 2021

Uh oh!

markwilkie commented Apr 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

dotnet-maestro bot commented Apr 9, 2021 •

edited

Loading

adamsitnik commented Apr 12, 2021 •

edited by carlossanlop

Loading

carlossanlop commented Apr 12, 2021 •

edited

Loading

markwilkie commented Apr 13, 2021 •

edited

Loading