[wasm][aot] Blazor template AOT fails in IcalTableGenerator

[lewing]

/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018: The "IcallTableGenerator" task failed unexpectedly. [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018: System.NotImplementedException: System.Threading.Thread [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.AppendType(StringBuilder sb, Type t) [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.AppendType(StringBuilder sb, Type t) [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.ProcessType(Type type) [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.GenIcallTable(String runtimeIcallTableFile, String[] assemblies) [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.Execute() [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/Users/lewing/Source/baot/baot.csproj]

https://github.com/dotnet/runtime/blob/main/src/tasks/WasmAppBuilder/IcallTableGenerator.cs#L175

current guess is it is from

#49637

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018: The "IcallTableGenerator" task failed unexpectedly. [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018: System.NotImplementedException: System.Threading.Thread [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.AppendType(StringBuilder sb, Type t) [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.AppendType(StringBuilder sb, Type t) [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.ProcessType(Type type) [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.GenIcallTable(String runtimeIcallTableFile, String[] assemblies) [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at IcallTableGenerator.Execute() [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/Users/lewing/Source/baot/baot.csproj]
/usr/local/share/dotnet/packs/Microsoft.NET.Runtime.WebAssembly.Sdk/6.0.0-preview.4.21211.7/Sdk/WasmApp.targets(426,4): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/Users/lewing/Source/baot/baot.csproj]

https://github.com/dotnet/runtime/blob/main/src/tasks/WasmAppBuilder/IcallTableGenerator.cs#L175

current guess is it is from

#49637

Author:	lewing
Assignees:	vargaz, CoffeeFlux
Labels:	arch-wasm, area-CoreLib-mono
Milestone:	6.0.0

[lewing]

This is blocking AOT for preview 4

cc @pranavkm

[pranavkm]

FYI @mkArtakMSFT

[CoffeeFlux]

The result is likely this change:

-        private static extern void InitializeCurrentThread_icall([NotNull] ref Thread? thread);
+        private static extern Thread GetCurrentThread();

I'm not clear on how this worked before though? A ref type would have hit this before:

runtime/src/tasks/WasmAppBuilder/IcallTableGenerator.cs

Lines 181 to 185 in c377f41

	else if (t.IsByRef)
	{
	AppendType (sb, t.GetElementType()!);
	sb.Append ('&');
	}

But then it should have tried the Thread? We also use that type in other icalls... @vargaz any ideas?

[lewing]

Let me check the versions here, this may be from before that pr

[radical]

The result is likely this change:

-        private static extern void InitializeCurrentThread_icall([NotNull] ref Thread? thread);
+        private static extern Thread GetCurrentThread();

I'm not clear on how this worked before though? A ref type would have hit this before:

runtime/src/tasks/WasmAppBuilder/IcallTableGenerator.cs

Lines 181 to 185 in c377f41

	else if (t.IsByRef)
	{
	AppendType (sb, t.GetElementType()!);
	sb.Append ('&');
	}

But then it should have tried the Thread? We also use that type in other icalls... @vargaz any ideas?

AFAICS:

1. AppendType is not used for return types
2. The trace has AppendType -> AppendType
   .. which would be consistent for a Thread& argument.

The change in the icall was:

        [MethodImplAttribute(MethodImplOptions.InternalCall)]
   -      private static extern void InitializeCurrentThread_icall([NotNull] ref Thread? thread);
   +      private static extern Thread GetCurrentThread();

3. The old one would be Thread&, and would fail with AppendType.

• But, this one never really gets processed because it is already present in the table generated for the runtime.

4. The new one, would not be passed to AppendType at all.

So.. I think this might be a case of old runtime(or cross compiler?), and a newer System.Private.CoreLib?

Please correct me if I'm wrong! I can't reproduce it locally, so I wasn't able to confirm my hypothesis!

[lewing]

Yeah I think the failure may actually have been with the previous version. This was with packaged versions flowing from aspnetcore it may be working in main

[lewing]

I think this was actually fixed by that pr, closing for now