-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add support for hot reload to hosted BlazorWasm apps #16701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 51 additions & 0 deletions
51
src/BuiltInTools/dotnet-watch/HotReload/BlazorWebAssemblyHostedDeltaApplier.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
// Copyright (c) .NET Foundation and contributors. All rights reserved. | ||
// Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
||
using System.Collections.Generic; | ||
using System.Collections.Immutable; | ||
using System.Threading; | ||
using System.Threading.Tasks; | ||
using Microsoft.CodeAnalysis.ExternalAccess.Watch.Api; | ||
using Microsoft.Extensions.Tools.Internal; | ||
|
||
namespace Microsoft.DotNet.Watcher.Tools | ||
{ | ||
internal class BlazorWebAssemblyHostedDeltaApplier : IDeltaApplier | ||
{ | ||
private readonly BlazorWebAssemblyDeltaApplier _wasmApplier; | ||
private readonly AspNetCoreDeltaApplier _hostApplier; | ||
|
||
public BlazorWebAssemblyHostedDeltaApplier(IReporter reporter) | ||
{ | ||
_wasmApplier = new BlazorWebAssemblyDeltaApplier(reporter); | ||
_hostApplier = new AspNetCoreDeltaApplier(reporter) | ||
{ | ||
SuppressBrowserRefreshAfterApply = true, | ||
}; | ||
} | ||
|
||
public async ValueTask InitializeAsync(DotNetWatchContext context, CancellationToken cancellationToken) | ||
{ | ||
await _wasmApplier.InitializeAsync(context, cancellationToken); | ||
await _hostApplier.InitializeAsync(context, cancellationToken); | ||
} | ||
|
||
public async ValueTask<bool> Apply(DotNetWatchContext context, string changedFile, ImmutableArray<WatchHotReloadService.Update> solutionUpdate, CancellationToken cancellationToken) | ||
{ | ||
return await _hostApplier.Apply(context, changedFile, solutionUpdate, cancellationToken) && | ||
await _wasmApplier.Apply(context, changedFile, solutionUpdate, cancellationToken); | ||
} | ||
|
||
public async ValueTask ReportDiagnosticsAsync(DotNetWatchContext context, IEnumerable<string> diagnostics, CancellationToken cancellationToken) | ||
{ | ||
// Both WASM and Host have similar implementations for diagnostics. We could pick either to report diagnostics. | ||
await _hostApplier.ReportDiagnosticsAsync(context, diagnostics, cancellationToken); | ||
} | ||
|
||
public void Dispose() | ||
{ | ||
_hostApplier.Dispose(); | ||
_wasmApplier.Dispose(); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This flag is saying that if an update was made to the host then browser doesn't need to refresh because unlike other AspNetCore scenarios the app being served in the browser is not running in the host but in the Blazor WASM side.
Is my understanding of that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default
AspNetCoreDeltaApplier
will attempt to either re-render components or refresh the browser after a delta has been applied. Since the WebAssembly one takes care of re-rendering, we kinda want this to no-op.