Add support for hot reload to hosted BlazorWasm apps #16701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix a bug where deltas where being sent in the wrong format to BlazorWASM * Allow recovering from compilation errors in a BlazorWASM app. Fixes dotnet/aspnetcore#30815
captainsafia
reviewed
Apr 2, 2021
| _wasmApplier = new BlazorWebAssemblyDeltaApplier(reporter); | ||
| _hostApplier = new AspNetCoreDeltaApplier(reporter) | ||
| { | ||
| SuppressBrowserRefreshAfterApply = true, |
There was a problem hiding this comment.
This flag is saying that if an update was made to the host then browser doesn't need to refresh because unlike other AspNetCore scenarios the app being served in the browser is not running in the host but in the Blazor WASM side.
Is my understanding of that correct?
There was a problem hiding this comment.
By default AspNetCoreDeltaApplier will attempt to either re-render components or refresh the browser after a delta has been applied. Since the WebAssembly one takes care of re-rendering, we kinda want this to no-op.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotalik
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/aspnetcore#30815