Skip to content

[wasm][debugger] Fix test failing on firefox #89607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2023
Merged

[wasm][debugger] Fix test failing on firefox #89607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1581,15 +1581,14 @@ public async Task<JObject> WaitForEventAsync(string eventName)
}
}

internal async Task SetJustMyCode(bool enabled)
internal virtual async Task SetJustMyCode(bool enabled)
{
var req = JObject.FromObject(new { JustMyCodeStepping = enabled });
var res = await cli.SendCommand("DotnetDebugger.setDebuggerProperty", req, token);
Assert.True(res.IsOk);
Assert.Equal(res.Value["justMyCodeEnabled"], enabled);
}


internal async Task SetSymbolOptions(JObject param)
{
var res = await cli.SendCommand("DotnetDebugger.setSymbolOptions", param, token);
Expand Down
2 changes: 2 additions & 0 deletions src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestFirefox.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,8 @@ private JObject ConvertFirefoxToDefaultFormat(JArray frames, JObject wait_res)
});
}

internal override Task SetJustMyCode(bool enabled) => Task.CompletedTask;

internal override async Task<JObject> SendCommandAndCheck(JObject args, string method, string script_loc, int line, int column, string function_name,
Func<JObject, Task> wait_for_event_fn = null, Func<JToken, Task> locals_fn = null, string waitForEvent = Inspector.PAUSE)
{
Expand Down