Skip to content

[wasm][debugger] Fix test failing on firefox #89607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

radical
Copy link
Member

@radical radical commented Jul 27, 2023

Do not send SetJustMyCode on firefox, as it does not support this
setting.

On-behalf-of: @thaystg

Fixes: #89602

@radical radical requested a review from thaystg as a code owner July 27, 2023 22:42
@radical radical added the arch-wasm WebAssembly architecture label Jul 27, 2023
@ghost ghost added the area-Debugger-mono label Jul 27, 2023
@ghost ghost assigned radical Jul 27, 2023
@ghost
Copy link

ghost commented Jul 27, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

arch-wasm

Milestone: -

@radical radical requested a review from lewing July 27, 2023 22:42
@radical
Copy link
Member Author

radical commented Jul 27, 2023

/azp run runtime-wasm-dbg-tests

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 89607 in repo dotnet/runtime

@radical
Copy link
Member Author

radical commented Jul 27, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Do not send `SetJustMyCode` on firefox, as it does not support this
setting.

On-behalf-of: @thaystg
@radical radical force-pushed the wasm-disabled-firefox-test branch from 7c71754 to 4e96a7c Compare July 28, 2023 00:40
@radical radical changed the title [wasm] Disable failing debugger test on firefox [wasm][debugger] Fix test failing on firefox Jul 28, 2023
@radical
Copy link
Member Author

radical commented Jul 28, 2023

/azp run runtime-wasm-dbgtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jul 28, 2023

Failures are unrelated, and expected.

@radical radical merged commit 5832fed into dotnet:main Jul 28, 2023
@radical radical deleted the wasm-disabled-firefox-test branch July 28, 2023 01:48
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm][debugger] Firefox test failure DebuggerTests.MiscTests.InspectPropertiesOfObjectFromExternalLibrary
3 participants