Skip to content

[PERF] Fix crossgen zip missing error #87662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 19, 2023
Merged

[PERF] Fix crossgen zip missing error #87662

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ba82e5c
Install zip tool on linux when not already installed.
LoopedBard3 Jun 13, 2023
269d396
Setup testing.
LoopedBard3 Jun 13, 2023
ea53e63
Install zip tool based on the available package managers.
LoopedBard3 Jun 13, 2023
2af4fcb
Only check for some package managers.
LoopedBard3 Jun 13, 2023
3b88f19
Add an ArchiveFiles step if the zip is not installed, to instead use …
LoopedBard3 Jun 13, 2023
41ddcbe
Fix typo in the script.
LoopedBard3 Jun 13, 2023
0412ce9
Fix windows machine variable assignment.
LoopedBard3 Jun 13, 2023
73df96c
Setup testing further.
LoopedBard3 Jun 14, 2023
9ae2c4f
Revert "Setup testing further."
LoopedBard3 Jun 14, 2023
b95b156
Fix Windows Zip Check display name.
LoopedBard3 Jun 14, 2023
989f0ef
Revert "Setup testing."
LoopedBard3 Jun 14, 2023
bb50a07
Only run ArchiveFiles for runKinds that use it.
LoopedBard3 Jun 15, 2023
24d8485
Revert "Revert "Setup testing.""
LoopedBard3 Jun 15, 2023
fc8231e
Fix pipeline error.
LoopedBard3 Jun 15, 2023
b120f0d
Setup testing only for ios mobile to ensure it still works.
LoopedBard3 Jun 15, 2023
5f23f36
Remove zip condition for actually zipping the files.
LoopedBard3 Jun 15, 2023
45df330
Revert "Setup testing only for ios mobile to ensure it still works."
LoopedBard3 Jun 16, 2023
408e8c9
Revert "Revert "Revert "Setup testing."""
LoopedBard3 Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions eng/pipelines/coreclr/templates/run-scenarios-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,13 +187,14 @@ jobs:
PERFLAB_TARGET_FRAMEWORKS: net7.0
condition: and(succeeded(), eq(variables['Agent.Os'], 'Darwin'))

# Zip the workitem directory (for xharness based workitems)
- task: ArchiveFiles@2
inputs:
rootFolderOrFile: '$(WorkItemDirectory)'
includeRootFolder: false
archiveFile: '$(WorkItemDirectory).zip'
verbose: True
# Zip the workitem directory (for xharness (mobile) based workitems)
- ${{ if or(eq(parameters.runKind, 'android_scenarios'), eq(parameters.runKind, 'ios_scenarios')) }}:
- task: ArchiveFiles@2
inputs:
rootFolderOrFile: '$(WorkItemDirectory)'
includeRootFolder: false
archiveFile: '$(WorkItemDirectory).zip'
verbose: True

# run perf testing in helix
- template: /eng/pipelines/coreclr/templates/perf-send-to-helix.yml
Expand Down