Skip to content

Conversation

@EgorBo
Copy link
Member

@EgorBo EgorBo commented Feb 23, 2023

Add recently added (MicrosoftDocs/sdk-api#1350) flag to detect RCPC ISA on Windows-ARM64. Linux-arm64 and macOS-arm64 are already able to detect it.

Should improve volatile reads on modern hardware (including Ampere)

@ghost ghost assigned EgorBo Feb 23, 2023
@jkotas
Copy link
Member

jkotas commented Feb 23, 2023

Could you please add it to

REDHAWK_PALIMPORT void REDHAWK_PALAPI PAL_GetCpuCapabilityFlags(int* flags)
as well?

@EgorBo
Copy link
Member Author

EgorBo commented Feb 23, 2023

@jkotas thanks, fixed. Does it look good now?

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jkotas jkotas merged commit c34ecd8 into dotnet:main Feb 23, 2023
@EgorBo EgorBo deleted the fix-rcpc-detection-win-arm64 branch February 23, 2023 23:43
@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants