Skip to content

[release/7.0] Crash when region survives >2GB #80392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 11, 2023
Merged

[release/7.0] Crash when region survives >2GB #80392

merged 3 commits into from
Jan 11, 2023

Conversation

mrsharm
Copy link
Member

@mrsharm mrsharm commented Jan 9, 2023 •
edited by jeffschwMSFT
Loading

Backport of #80302 that fixes #79486

Customer Impact

The impact of this bug is constrained to users who have very large LOH segments where one segment survives more than 2GB - leading to a crash.

Testing

We were able to test locally after consistently repro'ing the issue and proved that the fix took care of the bug.

Risk

Low risk change since it fixes the semantics of a type that was meant to be unsigned (from an int).

@ghost ghost added the area-GC-coreclr label Jan 9, 2023
@ghost ghost assigned mrsharm Jan 9, 2023
@mrsharm mrsharm requested a review from cshung January 9, 2023 21:13
@ghost
Copy link

ghost commented Jan 9, 2023

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #80302 that fixes #79486

Author: mrsharm
Assignees: -
Labels:

area-GC-coreclr
Milestone: -

@mrsharm mrsharm added the Servicing-consider Issue for next servicing release review label Jan 9, 2023
Maoni0
Maoni0 requested changes Jan 10, 2023
View reviewed changes
Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this actually doesn't look like it has most of the fix, for example, the part where it changes int to size_t for the survived field?

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 10, 2023
jeffschwMSFT
jeffschwMSFT approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 7.0.x

@jeffschwMSFT jeffschwMSFT added this to the 7.0.x milestone Jan 10, 2023
@tarekgh tarekgh mentioned this pull request Jan 10, 2023
Merged
@build-analysis build-analysis bot mentioned this pull request Jan 10, 2023
Closed
@mrsharm mrsharm marked this pull request as draft January 10, 2023 16:11
@jeffschwMSFT jeffschwMSFT changed the title Backport to 7.0 of 80302 that fixes #79486 [release/7.0] Crash when region survives >2GB Jan 10, 2023
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jan 10, 2023
@mrsharm mrsharm marked this pull request as ready for review January 10, 2023 17:00
@mrsharm
Copy link
Member Author

mrsharm commented Jan 10, 2023

Thanks for the review! This PR is now ready and has been tested by confirming:

  1. That the fix causes us to not AV thereby fixing the issue.
  2. That if the user specifies COMPlus_GCRegionSize >= 2GB, we return a CLR_E_GC_BAD_REGION_SIZE.

@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 10, 2023
@leecow leecow modified the milestones: 7.0.x, 7.0.3 Jan 10, 2023
@mrsharm mrsharm requested a review from Maoni0 January 10, 2023 21:18
@mrsharm
Copy link
Member Author

mrsharm commented Jan 11, 2023

Failures don't look related to the changes.

PeterSolMS
PeterSolMS approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@PeterSolMS PeterSolMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@carlossanlop
Copy link
Contributor

Approved by Tactics (7.0.3).
Signed off by area owners.
No OOB changes needed (native coreclr code).
All the CI failures are #80428
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit f5f9a70 into dotnet:release/7.0 Jan 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@Maoni0 Maoni0 Maoni0 approved these changes

@PeterSolMS PeterSolMS PeterSolMS approved these changes

@mangod9 mangod9 mangod9 approved these changes

@cshung cshung Awaiting requested review from cshung

Assignees

@mrsharm mrsharm

Labels
area-GC-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Milestone
7.0.3
Development

Successfully merging this pull request may close these issues.
7 participants
@mrsharm @carlossanlop @jeffschwMSFT @Maoni0 @PeterSolMS @mangod9 @leecow