Skip to content

Feature/logging messagetemplate compat #80364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 11, 2023

Conversation

tkrafael
Copy link
Contributor

@tkrafael tkrafael commented Jan 9, 2023

Continuing #79038:

  • Added documentation to private static methods, so it makes easier future contributions;
  • Added unit testing for [LSG] Objects logging using @ operator in logging source generator attribute #78013
  • Renaming methods so they're semantically correct when working with '$' symbols in variables
  • using Span when possible
  • Small bug during variable validation in parser: (src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs:358 in this commit)

@ghost ghost added area-Extensions-Logging community-contribution Indicates that the PR has been added by a community member labels Jan 9, 2023
@ghost
Copy link

ghost commented Jan 9, 2023

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

Continuing #79038:

  • Added documentation to private static methods, so it makes easier future contributions;
  • Added unit testing for [LSG] Objects logging using @ operator in logging source generator attribute #78013
  • Renaming methods so they're semantically correct when working with '$' symbols in variables
  • using Span when possible
  • Small bug during variable validation in parser: (src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Parser.cs:358 in this commit)
Author: tkrafael
Assignees: -
Labels:

area-Extensions-Logging, community-contribution

Milestone: -

@tarekgh tarekgh added this to the 8.0.0 milestone Jan 9, 2023
@tarekgh
Copy link
Member

tarekgh commented Jan 9, 2023

@tkrafael can you please resolve the conflict? You need to merge with the previous changes.

@tkrafael
Copy link
Contributor Author

Are checks failing because my changes? I'm looking at build pipeline and failing builds are related with macos and tvos

@tarekgh
Copy link
Member

tarekgh commented Jan 10, 2023

The failures do not look related to the changes. It shows in other PRs like #80392. Let's wait for the CI to finish and we can try restart these failures.

@tarekgh tarekgh merged commit 7ac3cde into dotnet:main Jan 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Logging community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants