[release/6.0] Fix dump creation on MacOS Ventura #79365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the task_info(TASK_DYLD_INFO) API to get the dylinker info instead of enumerating all the memory regions. This works on Ventura and simplifies the module enumeration quite a bit.
ghost
added
the
|
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #79356 to release/6.0 Use the task_info(TASK_DYLD_INFO) API to get the dylinker info instead of enumerating all the memory regions. This works on Ventura and simplifies the module enumeration quite a bit. Issue: #79355 Customer ImpactThis greatly affects VS4Mac Watson triage which 35% of their crash reports are on Ventura. TestingThe VS4Mac team has verified fix on both x64/arm64 Ventura. RiskLow risk. Affects only MacOS createdump.
|
mikem8361
changed the title
jeffschwMSFT
approved these changes
Dec 7, 2022
jeffschwMSFT
added
Servicing-approved
|
cc @mmitche |
hoyosjs
approved these changes
Dec 8, 2022
tommcdon
approved these changes
Dec 8, 2022
module is part of the core dump for the dump readers. They still need to look up the "dyld_all_image_infos" symbol.
|
Approved by Tactics (6.0.14). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #79356 to release/6.0
Use the task_info(TASK_DYLD_INFO) API to get the dylinker info instead of enumerating all the memory regions. This now works on the new MacOS version (Ventura) and simplifies the module enumeration quite a bit.
Issue: #79355
Customer Impact
The new MacOS version, Ventura, broke core dump generation. This greatly affects VS4Mac Watson triage.
Testing
The VS4Mac team has verified fix on both x64/arm64 Ventura.
Risk
Low risk. Affects only MacOS createdump.