Fix dump creation on MacOS Ventura #79356
Conversation
Use the task_info(TASK_DYLD_INFO) API to get the dylinker info instead of enumerating all the memory regions. This works on Ventura and simplifies the module enumeration quite a bit.
ghost
added
the
|
Tagging subscribers to this area: @tommcdon Issue DetailsUse the task_info(TASK_DYLD_INFO) API to get the dylinker info instead of enumerating all the memory regions. This works on Ventura and simplifies the module enumeration quite a bit. This greatly affects VS4Mac which 35% of their crash reports are on Ventura. Issue: #79355
|
|
cc @janvorli in case some extra review would be useful |
|
/backport to release/6.0 |
|
/backport to release/7.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/3642524580 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3642525290 |
|
@hoyosjs backporting to release/6.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix dump creation on MacOS Ventura
Using index info to reconstruct a base tree...
M src/coreclr/debug/createdump/crashinfo.h
M src/coreclr/debug/createdump/crashinfomac.cpp
Falling back to patching base and 3-way merge...
Auto-merging src/coreclr/debug/createdump/crashinfomac.cpp
CONFLICT (content): Merge conflict in src/coreclr/debug/createdump/crashinfomac.cpp
Auto-merging src/coreclr/debug/createdump/crashinfo.h
CONFLICT (content): Merge conflict in src/coreclr/debug/createdump/crashinfo.h
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix dump creation on MacOS Ventura
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@hoyosjs an error occurred while backporting to release/6.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
Use the task_info(TASK_DYLD_INFO) API to get the dylinker info instead of enumerating all the memory regions. This works on Ventura and simplifies the module enumeration quite a bit.
This greatly affects VS4Mac on Ventura.
Issue: #79355