[wasm] Implement Vector128.Abs intrinsics #78067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C# code
iv = Vector128.Abs(Vector128.Create(System.Random.Shared.Next()));
fv = Vector128.Abs(Vector128.Create(System.Random.Shared.NextSingle()));
dv = Vector128.Abs(Vector128.Create(System.Random.Shared.NextDouble()));
is emitted as:
...
i32x4.splat [SIMD]
i32x4.abs [SIMD]
v128.store offset:16 [SIMD]
...
f32x4.splat [SIMD]
f32x4.abs [SIMD]
v128.store [SIMD]
...
f64x2.splat [SIMD]
f64x2.abs [SIMD]
v128.store offset:80 [SIMD]
...
radekdoulik
requested review from
SamMonoRT,
lambdageek and
vargaz
as code owners
vargaz
reviewed
Nov 9, 2022
vargaz
approved these changes
Nov 9, 2022
This was referenced Nov 9, 2022
Member
Author
|
The build failures happen on main too, unrelated. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C# code
is emitted as: