Join the special sweep decision #75572
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few issues I introduced in #74625, and this PR is meant to fix them.
Without fixing these issues, the most common symptom is that because we are reading the
special_sweep_pflag in an arbitrary heap that reaches the join to decide whether or not we will compact, we might be compacting while some other heaps demand the special sweep, leading to missing regions when wethread_final_regions, having the same consequence as in #74401. There could be other bugs as well (e.g.special_sweep_pwas not reset beforemake_phasebegins, ...)Here are all the changes:
special_sweep_ptofalsefor each heap beforemark_phasestarts.special_sweep_pfor all heaps agree after joining for compaction decision.special_sweep_paUSE_REGIONSspecific field.