You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In process_last_np_surv_region, we set the special_sweep_p flag when we don't have a region after next_region = heap_segment_next (alloc_region) is null together with some other conditions that is irrelevant here.
Later, in process_remaining_regions, we assert that heap_segment_next_rw (current_region) == 0. I assume that it is checking the same thing, which is okay.
But special_sweep_p is a PER_HEAP_ISOLATED member, which means if one heap has that condition, it will set the flag for other heaps. On the other heaps, it is possible that the corresponding next_region is not null, thus triggering the assert.
Changing the flag from PER_HEAP_ISOLATED to a PER_HEAP member solved the issue.
Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.
Issue Details
In process_last_np_surv_region, we set the special_sweep_p flag when we don't have a region after next_region = heap_segment_next (alloc_region) is null together with some other conditions that is irrelevant here.
Later, in process_remaining_regions, we assert that heap_segment_next_rw (current_region) == 0. I assume that it is checking the same thing, which is okay.
But special_sweep_p is a PER_HEAP_ISOLATED member, which means if one heap has that condition, it will set the flag for other heaps. On the other heaps, it is possible that the corresponding next_region is not null, thus triggering the assert.
Changing the flag from PER_HEAP_ISOLATED to a PER_HEAP member solved the issue.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
locked as resolved and limited conversation to collaborators
In
process_last_np_surv_region, we set thespecial_sweep_pflag when we don't have a region afternext_region = heap_segment_next (alloc_region)is null together with some other conditions that is irrelevant here.Later, in
process_remaining_regions, we assert thatheap_segment_next_rw (current_region) == 0. I assume that it is checking the same thing, which is okay.But
special_sweep_pis aPER_HEAP_ISOLATEDmember, which means if one heap has that condition, it will set the flag for other heaps. On the other heaps, it is possible that the correspondingnext_regionis not null, thus triggering the assert.Changing the flag from
PER_HEAP_ISOLATEDto aPER_HEAPmember solved the issue.