Cleanup current directory tests #74311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace hardcoded list of platforms with symlinked temp directory with a relaxed condition that allows the test to pass even when the temp directory is symlinked.
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsReplace hardcoded list of platforms with symlinked temp directory with a relaxed condition that allows the test to pass even when the temp directory is symlinked.
|
Member
Author
|
Context #74070 (comment) |
jkotas
commented
Aug 21, 2022
| // path that followed the symlink. | ||
| if (!OperatingSystem.IsMacOS()) | ||
|
|
||
| if ((File.GetAttributes(Path.GetDirectoryName(TestDirectory)) & FileAttributes.ReparsePoint) != 0) |
Member
Author
There was a problem hiding this comment.
This file has the comprehensive current directory tests, so it gets more complicated checks unlike the other places.
jkotas
commented
Aug 21, 2022
|
|
||
| // We would ideally use realpath to do this, but it resolves symlinks, requires that the file actually exist, | ||
| // and turns it into a full path, which we only want if fullCheck is true. | ||
| // We would ideally use realpath to do this, but it resolves symlinks and requires that the file actually exist. |
Member
Author
There was a problem hiding this comment.
Somewhat related comment fix
/tmp does not seem to be an ordinary symlink
Member
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akoeplinger
approved these changes
Aug 22, 2022
mkhamoyan
approved these changes
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hardcoded list of platforms with symlinked temp directory with a relaxed condition that allows the test to pass even when the temp directory is symlinked.