Skip to content

Conversation

@mkhamoyan
Copy link
Contributor

@mkhamoyan mkhamoyan commented Aug 17, 2022

Fixes #52851

@ghost
Copy link

ghost commented Aug 17, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: mkhamoyan
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@mkhamoyan
Copy link
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

}

// On OSX, the temp directory /tmp/ is a symlink to /private/tmp, so setting the current
// On OSX/MacCatalyst, the temp directory /tmp/ is a symlink to /private/tmp, so setting the current
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can /tmp be a symlink on other OSes too? Would it be better for the test to check whether /tmp is a symlink and skip the validation as appropriate? It would save us from disabling the test one OS at a time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds better approach but I couldn't find how to check whether /tmp is a symlink.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds better approach but I couldn't find how to check whether /tmp is a symlink.

Console.WriteLine(((File.GetAttributes("/tmp") & FileAttributes.ReparsePoint) != 0) ? "Symlink" : "Not a symlink");

@ghost
Copy link

ghost commented Aug 17, 2022

Tagging subscribers to this area: @cston
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: mkhamoyan
Assignees: mkhamoyan
Labels:

area-Microsoft.VisualBasic

Milestone: -

@mkhamoyan mkhamoyan marked this pull request as ready for review August 18, 2022 14:25
@akoeplinger
Copy link
Member

Failures are unrelated.

@akoeplinger akoeplinger merged commit 7ab0899 into main Aug 18, 2022
@akoeplinger akoeplinger deleted the 52851_enable_maccatalyst_test branch August 18, 2022 15:33
@ghost ghost locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MacCatalyst][libraries] Microsoft.VisualBasic.Core.Tests failures

5 participants