Don't set PublishAot in SDK by default #74046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Member
|
/backport to release/7.0-rc1 |
Contributor
|
Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2872323345 |
This was referenced Aug 17, 2022
Member
Author
|
I did some amount of validation locally on a selection of the SDK tests that were failing in dotnet/sdk#27149 and am seeing them pass with this change. |
Member
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Also, |
Member
Props files don't know what we're going to target because they're included before users csproj that has those details. WASM builds include Windows targeting-related-props files as well; it's fine. They're not supposed to have side effects like this bug had, just set up the environment in a user-overridable way. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this as an alternative to reverting the PublishAot changes in #74036.
The intention was to default PublishAot to true when using the package reference, not when using the ILCompiler that ships with the SDK. These props get imported on both paths - I think it was just missing a check.