-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Closed
Description
Given that building a native AOT application is supported only via the SDK (with the option to get the latest ILCompiler* packs via an explicit reference), the publish path with properties, items, tasks, and targets etc., should be cleaned up. The history of this code has been with specific goals that have changed over time,
- The original code was added to only support explicit package references
- SDK support was added for
PublishAot
with backward compatibility support (for a short period) for the explicit package reference without the SDK path - The current support allows SDK only as well as to add explicit package reference with SDK
PublishAot
. Explicit package reference takes precedence when one exists (for example, to pick up bug fixes in the package earlier)
It should be easy to follow the publishing logic which currently is a little convoluted.
Specifically,
- Given that the package path is known early, RuntimePackagePath should be set early. This should be done in ProcessFrameworkReference target and its task
- Conditions that no longer make sense, like the checks for different paths for package paths should be removed
- Remove properties, (for example, IlcCalledViaPackage) that are no longer needed.
Regarding removing
IlcCalledViaPackage,
see this comment and dotnet/corert#5123
sbomer and NajimovMukhammad
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
In Progress