Skip to content

Retype pointers to 'this' on stack as unmanaged pointers #68074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Retype pointers to 'this' on stack as unmanaged pointers #68074

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e47c27a
Retype pointers to 'this' on stack as unmanaged pointers
jakobbotsch Apr 15, 2022
d897629
Fix aligning of promoted fields
jakobbotsch Apr 15, 2022
1d48be7
Revert "Fix aligning of promoted fields"
jakobbotsch Apr 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/coreclr/jit/morph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2239,9 +2239,7 @@ void CallArgs::AddFinalArgsAndDetermineABIInfo(Compiler* comp, GenTreeCall* call
// Change the node to TYP_I_IMPL so we don't report GC info
// NOTE: We deferred this from the importer because of the inliner.

// TODO-ARGS: Quirk this to match previous behavior. This optimization
// is not being done for 'this' pointer. It should be.
if ((arg.GetWellKnownArg() != WellKnownArg::ThisPointer) && argx->IsLocalAddrExpr() != nullptr)
if (argx->IsLocalAddrExpr() != nullptr)
{
argx->gtType = TYP_I_IMPL;
}
Expand Down Expand Up @@ -3224,9 +3222,9 @@ GenTreeCall* Compiler::fgMorphArgs(GenTreeCall* call)
DEBUG_ARG_SLOTS_ASSERT(size != 0);
DEBUG_ARG_SLOTS_ONLY(argSlots += arg.AbiInfo.GetSlotCount();)

// TODO-ARGS: Quirk this to match previous behavior where it was
// skipped for 'this' pointer. We should turn it off.
if ((arg.GetWellKnownArg() != WellKnownArg::ThisPointer) && (argx->IsLocalAddrExpr() != nullptr))
// For pointers to locals we can skip reporting GC info and also skip
// zero initialization.
if (argx->IsLocalAddrExpr() != nullptr)
{
argx->gtType = TYP_I_IMPL;
}
Expand Down