Retype pointers to 'this' on stack as unmanaged pointers #68074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove one of the quirks added in dotnet#67238.
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsRemove one of the quirks added in #67238. Initially I thought this would have nice diffs in terms of GC info, but it seems this does not end up costing too much. This also fixes the JITDUMP alignment of promoted fields with parent local nodes. In #67238 I increased the margin by a bit to be able to fit the kind of argument (e.g. "ret buffer" instead of "arg0"), but I missed updating this. cc @dotnet/jit-contrib
|
Do this in a separate PR.
BruceForstall
approved these changes
Apr 15, 2022
directhex
pushed a commit
to directhex/runtime
that referenced
this pull request
Apr 21, 2022
Remove one of the quirks added in the call args refactoring.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove one of the quirks added in #67238.
Initially I thought this would have nice diffs in terms of GC info, but it seems this does not end up costing too much.
cc @dotnet/jit-contrib