[release/7.0-preview2] Class types with layout that inherit from System.Object should be ManagedSequential #65578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
cc: @mangod9 I don't remember who needs to approve for servicing preview releases. Can you approve or do we need @jeffschwMSFT approval? |
AaronRobinsonMSFT
approved these changes
Feb 18, 2022
mangod9
approved these changes
Feb 18, 2022
|
I dont have access to merge though |
|
@jkoritzinsky the window to make Preview 2 has basically passed. How impactful is this? |
|
This can cause issues anywhere where LayoutKind.Sequential is used with ReadyToRun code, so not everywhere but at least somewhat common. I don't think this is release blocking though as the same bug was in Preview 1 and the fix is already in main. |
|
I think in this case, let' wait for main to flow into Preview 3. |
|
Sounds good. I’ll close this then. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #65447 to release/7.0-preview2
/cc @jkoritzinsky
Layout-classes marked as
LayoutKind.Sequentialwith a System.Object base class should use a sequential layout for managed code.Customer Impact
Users who use crossgen2 to Ready-to-Run their code before execution may experience unexpected failures when using
[StructLayout(LayoutKind.Sequential)]onclasstypes when interacting with non-R2R code.This is a regression reported in #65412
Testing
This PR includes tests to validate layout expectations.
Risk
Low risk.
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.