Skip to content

Class types with layout that inherit from System.Object should be ManagedSequential #65447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2022

Conversation

jkoritzinsky
Copy link
Member

Fixes #65412

@AaronRobinsonMSFT
Copy link
Member

Let's get a test for this. I would have thought we had one already. I'd like to ensure we have testing for all four of the below:

[StructLayout(LayoutKind.Sequential)]
class BaseSeq {}

class Derived : BaseSeq {}

class BaseAuto {}

[StructLayout(LayoutKind.Sequential)]
class Derived : BaseAuto {}

@jkoritzinsky
Copy link
Member Author

The test suites that failed here were deadlettered (probably due to capacity issues). Merging this in.

@jkoritzinsky jkoritzinsky merged commit ae259bf into dotnet:main Feb 18, 2022
@jkoritzinsky jkoritzinsky deleted the layoutfix branch February 18, 2022 18:05
@jkoritzinsky
Copy link
Member Author

/backport to release/7.0-preview2

@github-actions
Copy link
Contributor

Started backporting to release/7.0-preview2: https://github.com/dotnet/runtime/actions/runs/1865996343

@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling Win32 API CreateNamedPipe fails with ERROR_NOACCESS with PublishReadyToRun
2 participants