Skip to content

[release/6.0] bump sourcebuild leg timeout #63298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 5, 2022
Merged

[release/6.0] bump sourcebuild leg timeout #63298

merged 3 commits into from
Jan 5, 2022

Conversation

@safern
Copy link
Member

@safern safern commented Jan 3, 2022

This leg sometimes hits timeout on the official build as the 60 mins default timeout is too tight to how long it takes to finish.

This is a port of: #61436

@safern safern requested review from a team and danmoseley January 3, 2022 17:57
@ghost ghost assigned safern Jan 3, 2022
@ghost
Copy link

ghost commented Jan 3, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

This was referenced Jan 3, 2022
Closed
Closed
@safern
Copy link
Member Author

safern commented Jan 3, 2022

@agocke could you help me looking at the installer failures, they are completely unrelated and the first time I see them.

@ghost
Copy link

ghost commented Jan 4, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This leg sometimes hits timeout on the official build as the 60 mins default timeout is too tight to how long it takes to finish.

This is a port of: #61436

Author: safern
Assignees: safern
Labels:

area-Infrastructure
Milestone: -

@agocke
Copy link
Member

agocke commented Jan 4, 2022

Investigating now

agocke added 2 commits January 4, 2022 22:30
@agocke
Retry installer Process.Start if ETXTBSY (#59765)
b4d3753 
Caused by #58964

Fixes #53587

(cherry picked from commit 8dd058a)
@agocke
Up retry for ETXTBSY (#60741)
986ddcf 
* Up retry for ETXTBSY

Still seeing occasional failure in Alpine
(https://dev.azure.com/dnceng/public/_build/results?buildId=1434759) so
raising the retry time.

* Linearly scale wait time

(cherry picked from commit 6c09b7b)
@agocke
Copy link
Member

agocke commented Jan 5, 2022

Looks like this was a race condition that was fixed after the 6.0 snap. There's no direct relation to this PR -- it's just chance. I've backported the commits that include the fixes anyway.

@safern
Copy link
Member Author

safern commented Jan 5, 2022

Thanks, @agocke

@safern
Copy link
Member Author

safern commented Jan 5, 2022

Failures are known networking tests, I'm looking at why they are running as they're supposed to be disabled.

@safern safern merged commit 51b6749 into release/6.0 Jan 5, 2022
@safern safern deleted the updateSourceBuildTimeout60 branch January 5, 2022 19:08
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisok steveisok steveisok approved these changes

@agocke agocke agocke approved these changes

@danmoseley danmoseley Awaiting requested review from danmoseley

Assignees

@safern safern

Labels

area-Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@safern @agocke @steveisok @ericstj