Up retry for ETXTBSY (#60741)

agocke · web-flow · commit 6c09b7bfcaf6 · 2021-10-25T22:00:31.000-07:00
* Up retry for ETXTBSY Still seeing occasional failure in Alpine (https://dev.azure.com/dnceng/public/_build/results?buildId=1434759) so raising the retry time. * Linearly scale wait time
diff --git a/src/installer/tests/TestUtils/Command.cs b/src/installer/tests/TestUtils/Command.cs
@@ -206,11 +206,9 @@ public Command Start()
                     Process.Start();
                     break;
                 }
-                catch (Win32Exception e) when (i < 3 && e.Message.Contains("Text file busy"))
+                catch (Win32Exception e) when (i < 4 && e.Message.Contains("Text file busy"))
                 {
-                    // 10 ms is short, but the race we're trying to avoid is in-between
-                    // "fork" and "exec", so it should be fast
-                    Thread.Sleep(10);
+                    Thread.Sleep(i * 20);
                 }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -206,11 +206,9 @@ public Command Start()`
`206`	`206`	`Process.Start();`
`207`	`207`	`break;`
`208`	`208`	`}`
`209`		`- catch (Win32Exception e) when (i < 3 && e.Message.Contains("Text file busy"))`
	`209`	`+ catch (Win32Exception e) when (i < 4 && e.Message.Contains("Text file busy"))`
`210`	`210`	`{`
`211`		`- // 10 ms is short, but the race we're trying to avoid is in-between`
`212`		`- // "fork" and "exec", so it should be fast`
`213`		`- Thread.Sleep(10);`
	`211`	`+ Thread.Sleep(i * 20);`
`214`	`212`	`}`
`215`	`213`	`}`
`216`	`214`