Skip to content

Fixes an issue with FeatureSIMD=0 and ArmBase.Yield #62351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 4, 2021

Conversation

echesakov
Copy link
Contributor

@echesakov echesakov commented Dec 3, 2021

The issue is that ArmBase.Yield is not expanding as intrinsic when FeatureSIMD=0.
This shouldn't be a case.

In addition, this marks the intrinsic with HW_Flag_NoFloatingPointUsed.

Fixes #62117

…nsic and simplify the remaining logic in src/coreclr/jit/hwintrinsicarm64.cpp
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 3, 2021
@ghost
Copy link

ghost commented Dec 3, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #62117

Author: echesakovMSFT
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@echesakov
Copy link
Contributor Author

@dotnet/jit-contrib @tannergooding PTAL

@echesakov
Copy link
Contributor Author

/azp run runtime-coreclr jitstress-isas-arm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@echesakov echesakov merged commit 03b2885 into dotnet:main Dec 4, 2021
@echesakov echesakov deleted the Runtime_62117 branch December 4, 2021 23:11
@ghost ghost locked as resolved and limited conversation to collaborators Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: JIT/HardwareIntrinsics/Arm/ArmBase/Yield_r* on Arm64
3 participants