Skip to content

Add initial release testing for outerloop and jitstress pipelines #41856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

trylek
Copy link
Member

@trylek trylek commented Sep 4, 2020

I have fixed the CoreCLR outerloop pipeline to include the release
branches. For jitstress and libraries_jitstress I have split the
schedules to run every other day for master vs. release as with
the growing number of Mono runs there's not much space for maneuver
w.r.t. allocating new lab HW.

Fixes: #41841

Thanks

Tomas

P.S. There's not much I can do about validating that the updated
schedules actually work apart from just running the pipeline on the
PR to at least verify that the YAML is syntactically correct.

/cc: @dotnet/runtime-infrastructure

I have fixed the CoreCLR outerloop pipeline to include the release
branches. For jitstress and libraries_jitstress I have split the
schedules to run every other day for master vs. release as with
the growing number of Mono runs there's not much space for maneuver
w.r.t. allocating new lab HW.

Fixes: dotnet#41841

Thanks

Tomas
Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tomas :) I let the JIT team decide if they are ok with the alternating coverage. We would need to port this, right?

Copy link
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you could add Sunday runs to the cron for master or 5.0; currently you're not doing any run on Sunday -- previously it was every day.

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if we want this to work on release branches I believe we need to port it to them.

@trylek
Copy link
Member Author

trylek commented Sep 8, 2020

@safern - I must admit I'm somewhat confused here. When I click "Edit" on the "runtime-coreclr jitstress" pipeline definition, for instance, it claims to be using a YAML script off the "master" branch. Are you sure we need to port the change or should we loop in more people to help us clarify this?

@safern
Copy link
Member

safern commented Sep 8, 2020

That is the "default" branch where a build would be queued and the yml that would be used. However, when you run a build from a PR branch or a CI branch, it will use the yml that is checked in on that branch.

I have somewhat arbitrarily added a Sunday run for jitstress on
release branches and for libraries-jitstress on master; I don't
think I have any compelling reason for not doing it the other way
round, except perhaps for a bit of symmetry in the YAML code.

Thanks

Tomas
@trylek
Copy link
Member Author

trylek commented Sep 8, 2020

Thanks Santi for clarifying. I'll prepare a porting request after merging this in.

@trylek trylek merged commit 83b6659 into dotnet:master Sep 8, 2020
@trylek
Copy link
Member Author

trylek commented Sep 8, 2020

/backport to release/5.0-rc2

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2020

Started backporting to release/5.0-rc2: https://github.com/dotnet/runtime/actions/runs/245362567

@trylek trylek deleted the ReleaseOuterloop branch September 10, 2020 21:25
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime-coreclr outerloop not running against release branches
5 participants