fixed issue 36752 mail address display name #37874

jaymin93 · 2020-06-14T13:02:50Z

fixed issue 36752 mail address double quotes in DisplayName

link to issue

there are few issues i am facing with the unit test. if anything needs to be added please bring in to my attention. since this is my first pr i don't know much about process.

ghost · 2020-06-14T13:02:56Z

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

wfurt · 2020-06-14T22:30:35Z

You should add unit tests with reasonable coverage for the change @jaymin93

jaymin93 · 2020-06-23T10:04:40Z

I had hard time to write unit test on multiple machines it was not working apart from it I gave a try from other computer. I write some test for it but I can see there are existing code for mailadress parser.cs which does not allows double quotes and throwing the exception for the test so I need to edit those as well?

jaymin93 · 2020-06-23T10:05:34Z

By looking at that code it seems it means to not allow the quotes

wfurt · 2020-06-23T22:57:19Z

You should perkas get use cases from @J0nKn1ght . The linked issue was about printing so I would assume there is valid case with double quotes not requiting any production changes.
As far as the test results, I would not expect much variations in this are. You may try to build and run tests from command line.

for the issue #36752

dnfadmin · 2020-06-25T11:24:07Z

All CLA requirements met.

jaymin93 · 2020-06-25T11:29:26Z

i seen your comment and i tried to run the test from cli , but shows the same as one vs but anyway i tried to build a test with different computer and ran on that machine wrote same code and committed issue still persist but that will not stop me from making pr :) i added one test by reviewing the existing one , please let me know in case i need to do something else as well.

thanks for all help

src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/MailAddressDisplayNameTest.cs

wfurt

since this was viewed as part of serialization, I think should add more tests to make sure it actually works. (see the comment form @karelz)

wfurt · 2020-07-06T17:12:28Z

src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/MailAddressDisplayNameTest.cs

            Assert.Equal(string.Format("\"{0}\" <{1}>", DisplayNameWithUnicode, Address), _mailAddress.ToString());
        }

+


nit. extra line

ManickaP · 2020-07-07T07:47:59Z

src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/MailAddressDisplayNameTest.cs

+        public void MailAddress_WithDoubleQuotesDisplayAndMailAddress_ToStringShouldReturnDisplayNameEscapeSequenceAndAddressInAngleBrackets()
+        {
+            MailAddress _mailAddress = new MailAddress(Address, DisplayNameWithDoubleQuotes);
+            Assert.Equal(DisplayNameWithDoubleQuotes,_mailAddress.DisplayName );


If we're talking about the whitespaces, there's one missing after ',' and one extra before ')'.

ok @ManickaP i will add that and @wfurt can you help me with similar kind of test cases exist (path or source link ) so i can check out that and add necessary test for it , as well i seen comment of karelz but not quite sure that i understood it well if you can elaborate a bit that will help. thanks

@ManickaP can you help me with similar kind of test cases exist (path or source link ) so i can check out that and add necessary test for it.

@wfurt @ManickaP you want me to add serializable attribute to mailaddress.cs and add test cases for serialization wrapped with try catch ,is it correct , if not then please guide me so i can complete this pr thanks for all help

karelz

The serialization was meant to be "store into string" (as in opposite to parsing). No serialization attribute is necessary.

We should add couple of more corner case tests (@ManickaP has couple of more).

We should migrate these tests into MemberData -- it will be useful and simpler, given we have quite a few test cases now).
We could consider using the test as well for parsing -- parse string, then call .ToString() (check it is same) ... this is nice to have for this PR, not blocking.

karelz · 2020-07-20T09:24:51Z

src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/MailAddressDisplayNameTest.cs

+        [Fact]
+        public void MailAddress_WithDoubleQuotesDisplayAndMailAddress_ToStringShouldReturnDisplayNameEscapeSequenceAndAddressInAngleBrackets()
+        {
+            MailAddress _mailAddress = new MailAddress(Address, DisplayNameWithDoubleQuotes);


Nit remove leading '_' (even though the previous test has it, it should be fixed later as well -- in a separate PR ideally).
@ManickaP has even better idea to simplify tests in this file, again that should be separate issue / PR.

New issue: #39625

karelz · 2020-07-20T09:27:01Z

src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/MailAddressDisplayNameTest.cs

        private const string Address = "test@example.com";
        private const string DisplayNameWithUnicode = "DisplayNameWith\u00C9\u00C0\u0106\u0100\u0109\u0105\u00E4Unicode";
        private const string DisplayNameWithNoUnicode = "testDisplayName";
+        private const string DisplayNameWithDoubleQuotes = "test\"Display\"Name";


Add test cases:

""John Doe"" ... double quotes at the end

"Hello "world hello" world" ... double quotes in the middle around spaces - typical use case

"Hello "world" ... just one double quote (technically kind of incorrect value)

More test cases:

"Hello ""world" ... quotes next to each other

"""" ... only quotes (I don't know if it won't be rejected by MailAddress ctor)

""" ... single quote, nothing else

"Hello \"world hello\" world" ... escaped backslash before quotes (what's the behavior for this right now?)

karelz · 2020-07-20T09:32:50Z

BTW: What if \ is part of the display name? If it works as escape character, we may have to handle it as well ... again, something we can in a follow up PR.

jaymin93 · 2020-08-01T15:06:45Z

@ManickaP @karelz i had issue running tests locally , it never worked for me to run test locally , i know this is not ideal way but i tried to commit it and wanted to run as part of ci/cd pipeline .

it never worked on my 2 personal computer , it works on my work machine although changing to theory from fact and adding member data was not allowing to run on that machine as well so i don't have any other way to test . so could you please suggest.

test output are as below

Log level is set to Informational (Default).
Test data store opened in 0.219 sec.
---------- Starting test discovery for requested test run ----------
Using automatically detected runsettings file(s). To learn more visit https://aka.ms/vs-runsettings.
Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Testhost process exited with error: Could not resolve CoreCLR path. For more details, enable tracing by setting COREHOST_TRACE environment variable to 1
. Please check the diagnostic logs for more information.
at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.ThrowOnTestHostExited(Boolean testHostExited)
at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.SetupChannel(IEnumerable1 sources, String runSettings) at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyDiscoveryManager.DiscoverTests(DiscoveryCriteria discoveryCriteria, ITestDiscoveryEventsHandler2 eventHandler) ========== Test discovery aborted: 0 Tests found in 2.7 sec ========== Executing test method: System.Net.Mail.Tests.MailAddressDisplayNameTest.MailAddress_WithDoubleQuotesDisplayAndMailAddress_ToStringShouldReturnDisplayNameEscapeSequenceAndAddressInAngleBrackets ---------- Starting test run ---------- Using automatically detected runsettings file(s). To learn more visit https://aka.ms/vs-runsettings. ========== Test run finished: 0 Tests run in 182.5 ms (0 Passed, 0 Failed, 0 Skipped) ========== ---------- Starting test discovery ---------- Using automatically detected runsettings file(s). To learn more visit https://aka.ms/vs-runsettings. Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Testhost process exited with error: Could not resolve CoreCLR path. For more details, enable tracing by setting COREHOST_TRACE environment variable to 1 . Please check the diagnostic logs for more information. at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.ThrowOnTestHostExited(Boolean testHostExited) at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.SetupChannel(IEnumerable1 sources, String runSettings)
at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyDiscoveryManager.DiscoverTests(DiscoveryCriteria discoveryCriteria, ITestDiscoveryEventsHandler2 eventHandler)
Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Testhost process exited with error: Could not resolve CoreCLR path. For more details, enable tracing by setting COREHOST_TRACE environment variable to 1
. Please check the diagnostic logs for more information.
at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.ThrowOnTestHostExited(Boolean testHostExited)
at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.SetupChannel(IEnumerable1 sources, String runSettings) at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyDiscoveryManager.DiscoverTests(DiscoveryCriteria discoveryCriteria, ITestDiscoveryEventsHandler2 eventHandler) Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Testhost process exited with error: Could not resolve CoreCLR path. For more details, enable tracing by setting COREHOST_TRACE environment variable to 1 . Please check the diagnostic logs for more information. at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.ThrowOnTestHostExited(Boolean testHostExited) at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.SetupChannel(IEnumerable1 sources, String runSettings)
at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyDiscoveryManager.DiscoverTests(DiscoveryCriteria discoveryCriteria, ITestDiscoveryEventsHandler2 eventHandler)
========== Test discovery aborted: 0 Tests found in 410.8 ms ==========

karelz · 2020-08-01T16:57:15Z

Let's try to troubleshoot your local environment first. It will be IMO more efficient.
Can you file a new issue with description of steps you did and what doesn't work for you? Build vs. running tests.

jaymin93 · 2020-08-01T17:28:40Z

yes sure , I will create a new issue.

ManickaP · 2020-08-01T19:26:17Z

@jaymin93 According to the error message, it looks like you don't have CLR built. Have you followed the steps from here? You need to build the whole repository from the root first: build clr+libs -rc Release

jaymin93 · 2020-08-02T06:55:40Z

@ManickaP yes i was doing steps given in the link , to make sure i also executed the steps again but issue is same i think

Log level is set to Informational (Default).
Test data store opened in 0.021 sec.
---------- Starting test discovery for requested test run ----------
Using automatically detected runsettings file(s). To learn more visit https://aka.ms/vs-runsettings.
Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Testhost process exited with error: Could not resolve CoreCLR path. For more details, enable tracing by setting COREHOST_TRACE environment variable to 1
. Please check the diagnostic logs for more information.
at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.ThrowOnTestHostExited(Boolean testHostExited)
at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.SetupChannel(IEnumerable1 sources, String runSettings) at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyDiscoveryManager.DiscoverTests(DiscoveryCriteria discoveryCriteria, ITestDiscoveryEventsHandler2 eventHandler) ========== Test discovery aborted: 0 Tests found in 2.1 sec ========== Executing test method: System.Net.Mail.Tests.MailAddressDisplayNameTest.MailAddress_WithDoubleQuotesDisplayAndMailAddress_ToStringShouldReturnDisplayNameEscapeSequenceAndAddressInAngleBrackets ---------- Starting test run ---------- Using automatically detected runsettings file(s). To learn more visit https://aka.ms/vs-runsettings. ========== Test run finished: 0 Tests run in 137.7 ms (0 Passed, 0 Failed, 0 Skipped) ========== ---------- Starting test discovery ---------- Using automatically detected runsettings file(s). To learn more visit https://aka.ms/vs-runsettings. Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Testhost process exited with error: Could not resolve CoreCLR path. For more details, enable tracing by setting COREHOST_TRACE environment variable to 1 . Please check the diagnostic logs for more information. at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.ThrowOnTestHostExited(Boolean testHostExited) at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.SetupChannel(IEnumerable1 sources, String runSettings)
at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyDiscoveryManager.DiscoverTests(DiscoveryCriteria discoveryCriteria, ITestDiscoveryEventsHandler2 eventHandler)
Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Testhost process exited with error: Could not resolve CoreCLR path. For more details, enable tracing by setting COREHOST_TRACE environment variable to 1
. Please check the diagnostic logs for more information.
at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.ThrowOnTestHostExited(Boolean testHostExited)
at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.SetupChannel(IEnumerable1 sources, String runSettings) at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyDiscoveryManager.DiscoverTests(DiscoveryCriteria discoveryCriteria, ITestDiscoveryEventsHandler2 eventHandler) Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Testhost process exited with error: Could not resolve CoreCLR path. For more details, enable tracing by setting COREHOST_TRACE environment variable to 1 . Please check the diagnostic logs for more information. at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.ThrowOnTestHostExited(Boolean testHostExited) at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.SetupChannel(IEnumerable1 sources, String runSettings)
at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyDiscoveryManager.DiscoverTests(DiscoveryCriteria discoveryCriteria, ITestDiscoveryEventsHandler2 eventHandler)
========== Test discovery aborted: 0 Tests found in 940.1 ms ==========

should i open issue ?

jaymin93 · 2020-08-03T14:46:17Z

@ManickaP @karelz on my surface go i was able to execute the tests , but for the method with theory and member data i am getting below exception which is similar to the one i am getting on my work machine which was running test earlier , still my one machine with vs 2019 preview community latest preview is not able to run it , but since i am able to run it on one machine it's ok for me so for below issue do you have any suggestion?

[xUnit.net 00:00:31.24] System.NotSupportedException : Specified method is not supported.

Log level is set to Informational (Default).
Test data store opened in 0.650 sec.
---------- Starting test discovery for requested test run ----------
Using automatically detected runsettings file(s). To learn more visit https://aka.ms/vs-runsettings.
========== Test discovery skipped: All test containers are up to date ==========
Executing test method: System.Net.Mail.Tests.MailAddressDisplayNameTest.MailAddress_WithDoubleQuotesDisplayAndMailAddress_ToStringShouldReturnDisplayNameEscapeSequenceAndAddressInAngleBrackets
---------- Starting test run ----------
Using automatically detected runsettings file(s). To learn more visit https://aka.ms/vs-runsettings.
[xUnit.net 00:00:00.58] xUnit.net VSTest Adapter v2.4.2+2d84eb3141 (64-bit .NET 5.0.0-dev)
[xUnit.net 00:00:30.11] Starting: System.Net.Mail.Unit.Tests (parallel test collections = on, max threads = 4)
[xUnit.net 00:00:31.23] System.Net.Mail.Tests.MailAddressDisplayNameTest.MailAddress_WithDoubleQuotesDisplayAndMailAddress_ToStringShouldReturnDisplayNameEscapeSequenceAndAddressInAngleBrackets [FAIL]
[xUnit.net 00:00:31.24] System.NotSupportedException : Specified method is not supported.
[xUnit.net 00:00:31.37] Finished: System.Net.Mail.Unit.Tests
========== Test run finished: 1 Tests run in 54.4 sec (0 Passed, 1 Failed, 0 Skipped) ==========
---------- Starting test discovery ----------
Using automatically detected runsettings file(s). To learn more visit https://aka.ms/vs-runsettings.
[xUnit.net 00:00:00.02] xUnit.net VSTest Adapter v2.4.2+2d84eb3141 (64-bit .NET 5.0.0-dev)
[xUnit.net 00:00:03.46] Discovering: System.Net.Mail.Functional.Tests (method display = ClassAndMethod, method display options = None)
[xUnit.net 00:00:04.15] Discovered: System.Net.Mail.Functional.Tests (found 151 test cases)
========== Test discovery finished: 151 Tests found in 8.9 sec ==========

ManickaP · 2020-08-03T15:05:16Z

It's not MemberData but InlineData, MemberData are used for generating test data in a static method. Look through out code base how are those attributes used. Also, here's some nice blog post about it: https://andrewlock.net/creating-parameterised-tests-in-xunit-with-inlinedata-classdata-and-memberdata/

jaymin93 · 2020-08-03T16:32:00Z

@ManickaP thanks i have changed it to the inline data and it worked as expected , as you and karelz suggested i added suggested test in inline data , the only issue i see right now is when the quotes are at beginning and ending of the string it fail the test since the below link there is code to remove the quotes from start and end so i am not sure that needs to change as the comment suggest quotes will be added later but i do not see later they are added back from constructor so please suggest appropriate action.

runtime/src/libraries/System.Net.Mail/src/System/Net/Mail/MailAddress.cs

Line 145 in f1911f3

// Peal bounding quotes, they'll get re-added later.

ManickaP · 2020-08-04T13:14:37Z

they'll get re-added later. what happens then? What's the output in this case? Maybe push your last changes so we see the error in CI.

jaymin93 · 2020-08-07T06:19:02Z

@ManickaP thanks i have changed it to the inline data and it worked as expected , as you and karelz suggested i added suggested test in inline data , the only issue i see right now is when the quotes are at beginning and ending of the string it fail the test since the below link there is code to remove the quotes from start and end so i am not sure that needs to change as the comment suggest quotes will be added later but i do not see later they are added back from constructor so please suggest appropriate action.

runtime/src/libraries/System.Net.Mail/src/System/Net/Mail/MailAddress.cs

Line 145 in f1911f3

// Peal bounding quotes, they'll get re-added later.

@karelz can you please help me with your valuable opinion what should i do here since the if condition is for checking first and last quotes and only and current behavior of .net core 3.1(prod libs) that it is removing the quotes and doesn't added back if string has quotes in start and end for e.g ""John Doe"" will return "John Doe" test@example.com and that's where my tests are also failing, and i am also not aware what is exact use case for removing start and end quote in current code so your opinion will help me here. Thanks

ManickaP · 2020-08-07T09:23:36Z

The current behavior is correct, leading and trailing " must be stripped. This is to recognize whether the DisplayName is or isn't empty.
You should split your test cases to take this behavior into account.

jaymin93 · 2020-08-07T11:22:57Z

@ManickaP tried to implement with split tests as you suggested please review and share your views

ManickaP · 2020-08-07T11:27:21Z

@ManickaP tried to implement with split tests as you suggested please review and share your views

I'll give it another look, though probably after weekend.

ManickaP · 2020-08-11T17:34:35Z

src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/MailAddressDisplayNameTest.cs

        private const string DisplayNameWithUnicode = "DisplayNameWith\u00C9\u00C0\u0106\u0100\u0109\u0105\u00E4Unicode";
        private const string DisplayNameWithNoUnicode = "testDisplayName";

+


NIT: extra empty line

src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/MailAddressDisplayNameTest.cs

ManickaP · 2020-08-11T17:42:44Z

src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/MailAddressDisplayNameTest.cs

+            if (displayNameWithDoubleQuotesInBeginningAndInEnding.Length >= 2 && displayNameWithDoubleQuotesInBeginningAndInEnding[0] == '\"' && displayNameWithDoubleQuotesInBeginningAndInEnding[^1] == '\"')
+            {
+
+                displayNameWithDoubleQuotesInBeginningAndInEnding = displayNameWithDoubleQuotesInBeginningAndInEnding.Substring(1, displayNameWithDoubleQuotesInBeginningAndInEnding.Length - 2);


This is not testing what we want though. You're stripping the quotes before you pass it to the MailAddress ctor.

then what is suggested action here ?

Move the substring after the call of the MailAddress ctor.

ManickaP · 2020-08-11T17:45:06Z

src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/MailAddressDisplayNameTest.cs

+        [InlineData(Address, "\"\"")]
+        public void MailAddress_WithDoubleQuotesInBeginningAndInEndingDisplayAndMailAddress_ToStringShouldReturnDisplayNameEscapeSequenceAndAddressInAngleBrackets(string address, string displayNameWithDoubleQuotesInBeginningAndInEnding)
+        {
+            if (displayNameWithDoubleQuotesInBeginningAndInEnding.Length >= 2 && displayNameWithDoubleQuotesInBeginningAndInEnding[0] == '\"' && displayNameWithDoubleQuotesInBeginningAndInEnding[^1] == '\"')


You don't need the test here, the test is only for such data.

as you told me to split the test cases so i created separate test case for kind of test what would be recommended action here ?

In the comment, I mean the if since you already know it starts and ends with '"' by the definition of the test.

sorry i had internet issues and i was not able to review your comment properly , but now i have applied the all suggestion you told , please review it.

@ManickaP any update on review or merge status for pr ?

Looks good now, Karel have to approve as well though. Thanks for the patience and your contribution 👍

@ManickaP @karelz @wfurt i really appreciate all your feedback and valuable opinion and kind help, since I was new to github it self this is the first contribution I did in lifetime so I was kind of newbie but all your guidance and help made worth of contributing and really looking forward to do more love 😍 .net

…AddressDisplayNameTest.cs Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>

ManickaP

LGTM, thanks for the contribution!

ManickaP · 2020-08-24T12:53:30Z

@karelz since you requested change, you have to approve as well, otherwise the PR's blocked.

karelz

Thanks for working on it @jaymin93! Just few minor changes and one question left ...

src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/MailAddressDisplayNameTest.cs

…AddressDisplayNameTest.cs updated address in small case Co-authored-by: Karel Zikmund <karelz@microsoft.com>

…AddressDisplayNameTest.cs updated address in small a Co-authored-by: Karel Zikmund <karelz@microsoft.com>

jaymin93 · 2020-08-28T15:56:34Z

@ManickaP you told i need to merge into master and i am done with @karelz 's requested changes ,but i am not sure if i can merge (i think i must not have necessary rights to do same and i can not see any option do it but i can be wrong as well since i am new to github ) but anything from my end is required to do so i will do it so please suggest me what action i should take . Thanks

ManickaP · 2020-08-28T16:01:11Z

You're blocked by @karelz, he needs to approve first, than you can merge.

karelz

LGTM, thanks @jaymin93. Sorry for the delay 😔

jaymin93 · 2020-08-28T17:28:39Z

small help is needed @karelz , @ManickaP how can i merge this pr or .net team member will merge this pr into the master , I know it's newbie question and appreciate your kind help and suggestion thanks

ManickaP · 2020-08-28T17:54:37Z

Click the big green button with Squash and merge. 😄

jaymin93 · 2020-08-28T17:58:07Z

@ManickaP it shows "Only those with write access to this repository can merge pull requests." that button is not present in my case

fixed issue 36752 mail address displayname

aa1be52

Dotnet-GitSync-Bot added the area-System.Net label Jun 14, 2020

wfurt requested a review from a team June 14, 2020 22:32

added unit test for the double qoutes

1064352

for the issue #36752

ManickaP reviewed Jun 25, 2020

View reviewed changes

src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/MailAddressDisplayNameTest.cs Outdated Show resolved Hide resolved

updated order of assert equal

2c40297

wfurt reviewed Jul 6, 2020

View reviewed changes

ManickaP reviewed Jul 7, 2020

View reviewed changes

space removed as per suggestion

6a19647

karelz requested changes Jul 20, 2020

View reviewed changes

ManickaP mentioned this pull request Jul 20, 2020

Simplify MailAddressDisplayNameTest #39625

Closed

added more test cases , removed _ from mailaddress

8ec7528

inline tests

6a84ddd

spited test and added conditions to match empty display name

221e6c5

jaymin93 requested a review from karelz August 7, 2020 11:42

ManickaP reviewed Aug 11, 2020

View reviewed changes

jaymin93 and others added 6 commits August 12, 2020 00:17

Update src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/Mail…

2d8530a

…AddressDisplayNameTest.cs Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>

Update src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/Mail…

ec8331a

…AddressDisplayNameTest.cs Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>

suggested changes for name change and space removed

a49ad0b

Merge branch 'master' of https://github.com/jaymin93/runtime

afc3e74

removed if condition

efdfd64

moved sub string to after ctor

e6b2664

ManickaP approved these changes Aug 24, 2020

View reviewed changes

karelz requested changes Aug 25, 2020

View reviewed changes

jaymin93 and others added 4 commits August 25, 2020 16:30

Update src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/Mail…

cfe0575

…AddressDisplayNameTest.cs updated address in small case Co-authored-by: Karel Zikmund <karelz@microsoft.com>

Update src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/Mail…

5e088a2

…AddressDisplayNameTest.cs updated address in small a Co-authored-by: Karel Zikmund <karelz@microsoft.com>

Update src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/Mail…

8917106

…AddressDisplayNameTest.cs updated address in small a Co-authored-by: Karel Zikmund <karelz@microsoft.com>

added more test case as suggested

c11bfa8

ManickaP mentioned this pull request Aug 28, 2020

Simplified MailAddressDisplayNameTest (#39625) #39929

Merged

karelz approved these changes Aug 28, 2020

View reviewed changes

ManickaP merged commit 65d294d into dotnet:master Aug 28, 2020

ghost locked as resolved and limited conversation to collaborators Dec 8, 2020

karelz added this to the 6.0.0 milestone Jan 26, 2021

		Assert.Equal(string.Format("\"{0}\" <{1}>", DisplayNameWithUnicode, Address), _mailAddress.ToString());
		}

		private const string DisplayNameWithUnicode = "DisplayNameWith\u00C9\u00C0\u0106\u0100\u0109\u0105\u00E4Unicode";
		private const string DisplayNameWithNoUnicode = "testDisplayName";

fixed issue 36752 mail address display name #37874

fixed issue 36752 mail address display name #37874

Conversation

jaymin93 commented Jun 14, 2020 • edited by ManickaP Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jun 14, 2020

Uh oh!

wfurt commented Jun 14, 2020

Uh oh!

jaymin93 commented Jun 23, 2020

Uh oh!

jaymin93 commented Jun 23, 2020

Uh oh!

wfurt commented Jun 23, 2020

Uh oh!

dnfadmin commented Jun 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaymin93 commented Jun 25, 2020

Uh oh!

Uh oh!

wfurt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jaymin93 Jul 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

karelz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ManickaP Jul 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

karelz commented Jul 20, 2020

Uh oh!

jaymin93 commented Aug 1, 2020

Uh oh!

karelz commented Aug 1, 2020

Uh oh!

jaymin93 commented Aug 1, 2020

Uh oh!

ManickaP commented Aug 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaymin93 commented Aug 2, 2020

Uh oh!

jaymin93 commented Aug 3, 2020

Uh oh!

ManickaP commented Aug 3, 2020

Uh oh!

jaymin93 commented Aug 3, 2020

Uh oh!

ManickaP commented Aug 4, 2020

Uh oh!

jaymin93 commented Aug 7, 2020

Uh oh!

ManickaP commented Aug 7, 2020

Uh oh!

jaymin93 commented Aug 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ManickaP commented Aug 7, 2020

Uh oh!

jaymin93 commented Jun 14, 2020 •

edited by ManickaP

Loading

dnfadmin commented Jun 25, 2020 •

edited

Loading

jaymin93 Jul 8, 2020 •

edited

Loading

ManickaP Jul 20, 2020 •

edited

Loading

ManickaP commented Aug 1, 2020 •

edited

Loading

jaymin93 commented Aug 7, 2020 •

edited

Loading

jaymin93 commented Aug 28, 2020 •

edited

Loading