- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5.2k
Closed
Labels
area-System.Nethelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributorstest-enhancementImprovements of test source codeImprovements of test source code
Milestone
Description
Follow up of #37874
Many of the tests in MailAddressDisplayNameTest.cs are duplicates of the same test, only with different inputs.
--> Change the tests from [Fact] to [Theory] and parametrize them with [MemberData].
Some more clean up:
- some asserts have swapped expected and actual arguments: https://github.com/dotnet/runtime/blob/master/src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/MailAddressDisplayNameTest.cs#L44
- local variable with undesired underscore: https://github.com/dotnet/runtime/blob/master/src/libraries/System.Net.Mail/tests/Unit/MailAddressTests/MailAddressDisplayNameTest.cs#L63
Improvements to consider:
- reparse MailAddressfromToStringresult (depends on fixed issue 36752 mail address display name #37874)
Metadata
Metadata
Assignees
Labels
area-System.Nethelp wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributorstest-enhancementImprovements of test source codeImprovements of test source code