[WBT] enable coreCLR by pavelsavara · Pull Request #124850 · dotnet/runtime

pavelsavara · 2026-02-25T09:27:37Z

drop WasmBrowserRunMainOnly
add [TestCategory("native")] as necessary
always expect dotnet.diagnostics.js on CoreCLR
disable native trait for CoreCLR run
split off AOT tests

Passing: 59 Failing: 27

Copilot

Pull request overview

This pull request enables CoreCLR runtime testing in the WASM Build Tests suite by categorizing tests and filtering them appropriately based on the runtime flavor. The PR removes a CoreCLR-specific test asset that is no longer needed and ensures that tests requiring native builds, Mono-specific features, or workload installations are properly excluded when running with CoreCLR.

Changes:

Removed the WasmBrowserRunMainOnly test asset and test class, which was specifically created for CoreCLR but is no longer needed
Added TestCategory attributes to categorize tests as "native" (requiring AOT/native builds), "mono" (Mono-specific features), or "workload" (requiring workload installation)
Updated test filtering logic in Wasm.Build.Tests.csproj to exclude native/mono/workload tests when running with CoreCLR runtime
Modified WasmSdkBasedProjectProvider to expect diagnostics files for CoreCLR builds

Reviewed changes

Copilot reviewed 46 out of 46 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/mono/wasm/testassets/WasmBrowserRunMainOnly/*	Deleted entire test asset directory (6 files) that was specific to CoreCLR testing
src/mono/wasm/Wasm.Build.Tests/WasmBrowserRunMainOnly.cs	Deleted CoreCLR-specific test class
src/mono/wasm/Wasm.Build.Tests/BrowserStructures/TestAsset.cs	Removed WasmBrowserRunMainOnly test asset reference
src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj	Updated XUnit trait filtering to exclude native/mono/workload categories for CoreCLR
src/mono/wasm/Wasm.Build.Tests/WasmSdkBasedProjectProvider.cs	Added logic to expect diagnostics.js files for CoreCLR builds
src/mono/wasm/Wasm.Build.Tests/WorkloadTests.cs	Added "native" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/WasmBuildAppTest.cs	Added "native" category to AOT test methods
src/mono/wasm/Wasm.Build.Tests/WasmSIMDTests.cs	Added "native" category to PublishSIMD_AOT test
src/mono/wasm/Wasm.Build.Tests/WasmNativeDefaultsTests.cs	Added "native" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs	Added "workload" and "native" categories to various template tests
src/mono/wasm/Wasm.Build.Tests/Templates/NativeBuildTests.cs	Added "native" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/SatelliteAssembliesTests.cs	Added "native" category to resource assembly tests
src/mono/wasm/Wasm.Build.Tests/PInvokeTableGeneratorTests.cs	Added "native" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/NativeRebuildTests/*	Added "native" category to all native rebuild test classes (5 files)
src/mono/wasm/Wasm.Build.Tests/NativeLibraryTests.cs	Added "native" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/NativeBuildTests.cs	Added "native" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/ModuleConfigTests.cs	Split SymbolMapFileEmitted test into two separate tests, marking only the emitting case as "native"
src/mono/wasm/Wasm.Build.Tests/MemoryTests.cs	Added "native" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs	Added "native" category to main-with-args tests
src/mono/wasm/Wasm.Build.Tests/InvariantTimezoneTests.cs	Added "native" category to invariant timezone tests
src/mono/wasm/Wasm.Build.Tests/InvariantGlobalizationTests.cs	Added "native" category to invariant globalization tests
src/mono/wasm/Wasm.Build.Tests/InterpPgoTests.cs	Added "mono" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/IcuTests.cs	Added "native" and "workload" categories to ICU tests
src/mono/wasm/Wasm.Build.Tests/IcuShardingTests*.cs	Added "native" category to ICU sharding tests (2 files)
src/mono/wasm/Wasm.Build.Tests/DllImportTests.cs	Added "native" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/DiagnosticsTests.cs	Added "mono" category to class-level TestCategory
src/mono/wasm/Wasm.Build.Tests/BuildPublishTests.cs	Added "native" category to AOT publish tests
src/mono/wasm/Wasm.Build.Tests/Blazor/*	Added "native" and "mono" categories to various Blazor tests (8 files)

Copilot

Pull request overview

Copilot reviewed 49 out of 49 changed files in this pull request and generated 3 comments.

eng/pipelines/global-build.yml

eng/pipelines/runtime-linker-tests.yml

src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj

Copilot

Pull request overview

Copilot reviewed 50 out of 50 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 53 out of 53 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/libraries/sendtohelix-wasm.targets:70

For RuntimeFlavor=CoreCLR the per-class HelixWorkItem is created even when TestUsingWorkloads=false, but the aggregate Wasm.Build.Tests work item is also created because its condition includes $(TestUsingWorkloads) != 'true'. This will schedule the same tests twice in CoreCLR BuildWasmApps jobs. Update the conditions so CoreCLR runs either the per-class work items or the aggregate work item, but not both (e.g., gate the CoreCLR per-class items on TestUsingWorkloads=='true', or exclude RuntimeFlavor=CoreCLR from the aggregate condition when per-class splitting is enabled).

      <HelixWorkItem Include="@(BuildWasmApps_PerJobList->'$(WorkItemPrefix)%(Identity)')" Condition="'$(RuntimeFlavor)' == 'CoreCLR' and '$(WasmFingerprintAssets)' == 'true' and '$(WasmBundlerFriendlyBootConfig)' == 'false'">
        <PayloadArchive>$(_BuildWasmAppsPayloadArchive)</PayloadArchive>
        <PreCommands>$(EnvVarCommand) &quot;HELIX_XUNIT_ARGS=-class %(Identity)&quot;</PreCommands>
        <Command>$(HelixCommand)</Command>
        <Timeout>$(_workItemTimeout)</Timeout>
      </HelixWorkItem>

      <HelixWorkItem Include="$(WorkItemPrefix)Wasm.Build.Tests" Condition="'$(TestUsingWorkloads)' != 'true' or '$(WasmFingerprintAssets)' != 'true' or '$(WasmBundlerFriendlyBootConfig)' != 'false'">
        <PayloadArchive>$(_BuildWasmAppsPayloadArchive)</PayloadArchive>
        <Command>$(HelixCommand)</Command>
        <Timeout>$(_workItemTimeout)</Timeout>
      </HelixWorkItem>

src/mono/wasm/testassets/WasmBasicTestApp/App/wwwroot/main.js

src/libraries/sendtohelix-browser.targets

Copilot

Pull request overview

Copilot reviewed 56 out of 56 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/libraries/sendtohelix-wasm.targets:64

The CoreCLR work item condition on line 59 does not check for TestUsingWorkloads like the Mono condition on line 52 does. This means CoreCLR tests will run even when TestUsingWorkloads is 'false', while Mono tests require workloads. Is this intentional? If CoreCLR WASM requires workloads to function, the condition should include the same '$(TestUsingWorkloads)' == 'true' check. Otherwise, the test could fail in non-workload scenarios for CoreCLR.

      <HelixWorkItem Include="@(BuildWasmApps_PerJobList->'$(WorkItemPrefix)%(Identity)')" Condition="'$(RuntimeFlavor)' == 'CoreCLR' and '$(WasmFingerprintAssets)' == 'true' and '$(WasmBundlerFriendlyBootConfig)' == 'false'">
        <PayloadArchive>$(_BuildWasmAppsPayloadArchive)</PayloadArchive>
        <PreCommands>$(EnvVarCommand) &quot;HELIX_XUNIT_ARGS=-class %(Identity)&quot;</PreCommands>
        <Command>$(HelixCommand)</Command>
        <Timeout>$(_workItemTimeout)</Timeout>
      </HelixWorkItem>

src/mono/wasm/Wasm.Build.Tests/WasmBuildAppTest.cs

eng/testing/scenarios/BuildWasmAppsJobsListCoreCLR.txt

Copilot

Pull request overview

Copilot reviewed 56 out of 56 changed files in this pull request and generated 1 comment.

src/libraries/sendtohelix-browser.targets

Copilot

Pull request overview

Copilot reviewed 56 out of 56 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

src/libraries/sendtohelix-wasm.targets:70

In BuildWasmApps, when RuntimeFlavor=CoreCLR and TestUsingWorkloads is not true, this target will create both the per-class HelixWorkItem entries (line 59 condition does not check TestUsingWorkloads) and the fallback Wasm.Build.Tests work item (line 66 condition becomes true because TestUsingWorkloads != 'true'). This likely duplicates test execution. Consider gating the fallback item (or the CoreCLR per-class items) so only one set of work items is produced for CoreCLR runs.

      <HelixWorkItem Include="@(BuildWasmApps_PerJobList->'$(WorkItemPrefix)%(Identity)')" Condition="'$(RuntimeFlavor)' == 'CoreCLR' and '$(WasmFingerprintAssets)' == 'true' and '$(WasmBundlerFriendlyBootConfig)' == 'false'">
        <PayloadArchive>$(_BuildWasmAppsPayloadArchive)</PayloadArchive>
        <PreCommands>$(EnvVarCommand) &quot;HELIX_XUNIT_ARGS=-class %(Identity)&quot;</PreCommands>
        <Command>$(HelixCommand)</Command>
        <Timeout>$(_workItemTimeout)</Timeout>
      </HelixWorkItem>

      <HelixWorkItem Include="$(WorkItemPrefix)Wasm.Build.Tests" Condition="'$(TestUsingWorkloads)' != 'true' or '$(WasmFingerprintAssets)' != 'true' or '$(WasmBundlerFriendlyBootConfig)' != 'false'">
        <PayloadArchive>$(_BuildWasmAppsPayloadArchive)</PayloadArchive>
        <Command>$(HelixCommand)</Command>
        <Timeout>$(_workItemTimeout)</Timeout>
      </HelixWorkItem>

Copilot

Pull request overview

Copilot reviewed 56 out of 56 changed files in this pull request and generated no new comments.

pavelsavara added 2 commits February 25, 2026 10:25

drop WasmBrowserRunMainOnly

4a3cbb0

wip

8e8806c

pavelsavara added this to the 11.0.0 milestone Feb 25, 2026

pavelsavara self-assigned this Feb 25, 2026

Copilot AI review requested due to automatic review settings February 25, 2026 09:27

pavelsavara added arch-wasm WebAssembly architecture area-Infrastructure-coreclr os-browser Browser variant of arch-wasm labels Feb 25, 2026

github-project-automation bot added this to Runtime Infra Feb 25, 2026

Copilot started reviewing on behalf of pavelsavara February 25, 2026 09:28 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

pavelsavara requested a review from radekdoulik February 25, 2026 10:01

ilonatommy added 2 commits February 25, 2026 11:46

TMP: shorten the dev loop, disable lanes that we're not fixing.

10c3308

Enable WBT for CoreCLR.

16535e5

Copilot AI review requested due to automatic review settings February 25, 2026 10:49

Copilot started reviewing on behalf of ilonatommy February 25, 2026 10:50 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

eng/pipelines/global-build.yml Outdated Show resolved Hide resolved

eng/pipelines/runtime-linker-tests.yml Outdated Show resolved Hide resolved

src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj Show resolved Hide resolved

Remove TMP changes.

0b92d26

build-analysis bot mentioned this pull request Feb 25, 2026

[android][clr] No peer certificates when executing System.Net.Http.Functional.Tests on Android emulator #124526

Open

job list for coreCLR

3bc6c76

Copilot AI review requested due to automatic review settings February 25, 2026 16:35

Copilot started reviewing on behalf of pavelsavara February 25, 2026 16:36 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

build-analysis bot mentioned this pull request Feb 25, 2026

Wasm build terminated with exit code 137 #108299

Open

Fix 0 tests matched on CI.

e7f36c4

Copilot started reviewing on behalf of ilonatommy February 26, 2026 14:14 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

src/mono/wasm/testassets/WasmBasicTestApp/App/wwwroot/main.js Show resolved Hide resolved

src/libraries/sendtohelix-browser.targets Show resolved Hide resolved

ilonatommy added 2 commits February 26, 2026 20:37

Not skip but conditional theroy/fact.

4532a9d

Apply copilot's feedback to fix CI.

ec03bb8

Copilot AI review requested due to automatic review settings February 26, 2026 19:42

Copilot started reviewing on behalf of ilonatommy February 26, 2026 19:43 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

src/mono/wasm/Wasm.Build.Tests/WasmBuildAppTest.cs Show resolved Hide resolved

maraf reviewed Feb 26, 2026

View reviewed changes

eng/testing/scenarios/BuildWasmAppsJobsListCoreCLR.txt Show resolved Hide resolved

ilonatommy added 2 commits February 26, 2026 21:00

Rename.

ee03e6c

Fix rename...

2b1efbe

Copilot AI review requested due to automatic review settings February 26, 2026 20:01

Copilot started reviewing on behalf of ilonatommy February 26, 2026 20:02 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

src/libraries/sendtohelix-browser.targets Outdated Show resolved Hide resolved

ilonatommy added 2 commits February 27, 2026 08:35

Feedback.

3820e3d

Block failing ModuleConfigTests

2801f99

Copilot AI review requested due to automatic review settings February 27, 2026 07:58

Copilot started reviewing on behalf of ilonatommy February 27, 2026 07:59 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

WasmFingerprintAssets is not set for coreclr so it cannot rely on it.

8128d76

ilonatommy marked this pull request as ready for review February 27, 2026 11:19

Copilot AI review requested due to automatic review settings February 27, 2026 11:19

ilonatommy requested a review from akoeplinger as a code owner February 27, 2026 11:19

Copilot started reviewing on behalf of ilonatommy February 27, 2026 11:20 View session

Feedbck: add await.

d958812

Copilot AI reviewed Feb 27, 2026

View reviewed changes

ilonatommy approved these changes Feb 27, 2026

View reviewed changes

ilonatommy enabled auto-merge (squash) February 27, 2026 11:38

This was referenced Feb 27, 2026

[coreclr] CoreCLR does not load correct satellite resources #124901

Open

[coreclr] Throttling of parallel downloads is supported #124964

Open

build-analysis bot mentioned this pull request Feb 27, 2026

Android WebSocket failure #121518

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WBT] enable coreCLR#124850

[WBT] enable coreCLR#124850
pavelsavara wants to merge 24 commits intodotnet:mainfrom
pavelsavara:wbt_coreclr

pavelsavara commented Feb 25, 2026 •

edited by ilonatommy

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

pavelsavara commented Feb 25, 2026 • edited by ilonatommy Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pavelsavara commented Feb 25, 2026 •

edited by ilonatommy

Loading